Bug 125011 – JSC does not build if OPCODE_STATS is enabled.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[László Langó]

JSC does not build if OPCODE_STATS is enabled.

[László Langó]

Created attachment 218060 [details]
Patch

[Filip Pizlo]

Comment on attachment 218060 [details]
Patch

This is another one of those options that we should remove. It's entirely subsumed by the new profiler, which is always built and can be enabled with a runtime flag.

[WebKit Commit Bot]

Comment on attachment 218060 [details]
Patch

Clearing flags on attachment: 218060

Committed r159933: <http://trac.webkit.org/changeset/159933>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Fujii Hironori]

If define ENABLE_OPCODE_STATS 1, can't compile due to other issues.

> In file included from DerivedSources\JavaScriptCore\unified-sources\UnifiedSource-f0a787a9-8.cpp:6:
> ..\..\Source\JavaScriptCore\bytecode/Opcode.cpp(97,38): error: no template named 'pair'; did you mean 'std::pair'?
>     std::pair<int, int> leftPair = *(pair<int, int>*) left;
>                                      ^~~~
>                                      std::pair
> C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\utility(93,9): note: 'std::pair' declared here
>         struct pair
>                ^
> In file included from DerivedSources\JavaScriptCore\unified-sources\UnifiedSource-f0a787a9-8.cpp:6:
> ..\..\Source\JavaScriptCore\bytecode/Opcode.cpp(99,39): error: no template named 'pair'; did you mean 'std::pair'?
>     std::pair<int, int> rightPair = *(pair<int, int>*) right;
>                                       ^~~~
>                                       std::pair
> C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\utility(93,9): note: 'std::pair' declared here
>         struct pair
>                ^
> 2 errors generated.