Bug 125003 - [EFL] HTML5 required attribute validation messages implemented
Summary: [EFL] HTML5 required attribute validation messages implemented
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-29 01:41 PST by Attila Dusnoki
Modified: 2013-12-02 03:28 PST (History)
7 users (show)

See Also:

Attachments
Proposed patch (3.01 KB, patch)
2013-11-29 01:43 PST, Attila Dusnoki 		no flags Details | Formatted Diff | Diff
Proposed patch (3.01 KB, patch)
2013-11-29 02:26 PST, Attila Dusnoki 		no flags Details | Formatted Diff | Diff
Proposed patch (2.98 KB, patch)
2013-12-02 00:23 PST, Attila Dusnoki 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Attila Dusnoki 2013-11-29 01:41:51 PST 
Implemented missing HTML5 validation messages.
Comment 1 Attila Dusnoki 2013-11-29 01:43:10 PST 
Created attachment 218040 [details]
Proposed patch
Comment 2 Attila Dusnoki 2013-11-29 02:26:13 PST 
Created attachment 218045 [details]
Proposed patch
Comment 3 Gyuyoung Kim 2013-11-30 21:33:56 PST 
Comment on attachment 218045 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218045&action=review

> Source/WebCore/ChangeLog:7
> +

It would be nicer to add description, though patch is too simple.

> Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:531
> +    return String::fromUTF8("Please match the requested format:");

As far as I know, ASCIILiteral is more efficient than String::fromUTF8().

http://trac.webkit.org/wiki/EfficientStrings
Comment 4 Attila Dusnoki 2013-12-02 00:23:48 PST 
Created attachment 218144 [details]
Proposed patch
Comment 5 Gyuyoung Kim 2013-12-02 00:41:04 PST 
LGTM
Comment 6 WebKit Commit Bot 2013-12-02 01:05:46 PST 
Comment on attachment 218144 [details]
Proposed patch

Clearing flags on attachment: 218144

Committed r159915: <http://trac.webkit.org/changeset/159915>
Comment 7 WebKit Commit Bot 2013-12-02 01:05:50 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Gyuyoung Kim 2013-12-02 03:28:58 PST 
EFL layout test regression occurred. So, I fix it on http://trac.webkit.org/changeset/159929.