Bug 125000 – [WebGL] Wrong condition order in the if statement

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Przemyslaw Szymanski]

We should make a more efficient if statements. In this case bool variable should be checked before string comparison. Only in one case (first check) a string variable will be compare. After that a bool variable is set and string should not be compare again.

[Przemyslaw Szymanski]

Created attachment 218042 [details]
patch

[Brent Fulgham]

Comment on attachment 218042 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218042&action=review

You are right!  Let's clean the change log up slightly and get this landed.

> Source/WebCore/ChangeLog:3
> +        [WebGL] Wrong condition order in the if statement

[WebGL] Revise condition order for better performance

> Source/WebCore/ChangeLog:12
> +        this method.

Please Rephrase: We should revise the logic so that we only pay the cost of string comparison once.  The current logic causes the string comparison to happen every time we enter this function. Instead, by reordering the statements we can do a simple boolean test after the initial setup is complete.

[Brent Fulgham]

Comment on attachment 218042 [details]
patch

r=me. I'll fix the Changelog while landing.

[Brent Fulgham]

Committed r161645: <http://trac.webkit.org/changeset/161645>

[Przemyslaw Szymanski]

(In reply to comment #3)
> (From update of attachment 218042 [details])
> r=me. I'll fix the Changelog while landing.

Thank you very much for review of my patches. Unfortunately I didn't have time for update this commit message. Please be my guest to do this.

cq?