Bug 124988 - Revert the X86 assembler peephole changes
Summary: Revert the X86 assembler peephole changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nadav Rotem
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-28 11:03 PST by Nadav Rotem
Modified: 2013-11-28 12:31 PST (History)
3 users (show)

See Also:


Attachments
Patch (8.54 KB, patch)
2013-11-28 11:04 PST, Nadav Rotem
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nadav Rotem 2013-11-28 11:03:44 PST
Revert the X86 assembler peephole changes
Comment 1 Nadav Rotem 2013-11-28 11:04:00 PST
Created attachment 218019 [details]
Patch
Comment 2 Nadav Rotem 2013-11-28 11:04:26 PST
This patch reverts: https://bugs.webkit.org/show_bug.cgi?id=124904
Comment 3 Nadav Rotem 2013-11-28 11:06:49 PST
Comment on attachment 218019 [details]
Patch

No need for review because I am only reverting a previous change.
Comment 4 Csaba Osztrogonác 2013-11-28 11:34:56 PST
Comment on attachment 218019 [details]
Patch

CQ won't land _without_ r+ and _with_ "Reviewed by NOBODY (OOPS!).", so rs=me for now.
If you would like to land unreviewed patch, just remove this line and don't set review flag.
Comment 5 Filip Pizlo 2013-11-28 11:50:46 PST
(In reply to comment #4)
> (From update of attachment 218019 [details])
> CQ won't land _without_ r+ and _with_ "Reviewed by NOBODY (OOPS!).", so rs=me for now.
> If you would like to land unreviewed patch, just remove this line and don't set review flag.

Or just svn commit directly!  Also there's usually no need for a bug for rollouts. 

Rollouts and build fixes usually just have a changelog message like "Unreviewed, revert r1234" or "Unreviewed, fix build". No need for the other changelog stuff. We're not terribly strict about how you do it though.
Comment 6 WebKit Commit Bot 2013-11-28 12:31:08 PST
Comment on attachment 218019 [details]
Patch

Clearing flags on attachment: 218019

Committed r159855: <http://trac.webkit.org/changeset/159855>
Comment 7 WebKit Commit Bot 2013-11-28 12:31:10 PST
All reviewed patches have been landed.  Closing bug.