Bug 124987 – Nix Upstream: Adding missing nix new files to WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Thiago de Barros Lacerda]

Nix specific files

[Thiago de Barros Lacerda]

Created attachment 218020 [details]
Patch

[Benjamin Poulain]

Comment on attachment 218020 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218020&action=review

> Source/WebCore/platform/nix/FileSystemNix.cpp:49
> +/* On linux file names are just raw bytes, so also strings that cannot be encoded in any way
> + * are valid file names. This mean that we cannot just store a file name as-is in a String
> + * but we have to escape it.
> + * On Windows the GLib file name encoding is always UTF-8 so we can optimize this case. */

This file is in WebCore/platform. It should use regular comment style.

> Source/WebCore/platform/nix/FileSystemNix.cpp:208
> +    static CString cachedPath;

This needs DEFINE_STATIC_LOCAL.

> Source/WebCore/platform/nix/FileSystemNix.cpp:230
> +    /* No null checking needed */

Comment style.

This comment does not add much. It does not explain the "why" of the code.

> Source/WebCore/platform/nix/MIMETypeRegistryNix.cpp:87
> +    String s = ext.lower();
> +    const ExtensionMap *e = extensionMap;
> +    while (e->extension) {
> +        if (s == e->extension)
> +            return e->mimeType;
> +        ++e;
> +    }

Name the variables, "s" and "e" is no good.

> Source/WebCore/platform/nix/SharedTimerNix.cpp:45
> +void setSharedTimerFiredFunction(void (*f)())
> +{
> +    sharedTimerFiredFunction = f;
> +}

Name "f"?

[Thiago de Barros Lacerda]

Created attachment 218226 [details]
Patch

[Benjamin Poulain]

Comment on attachment 218226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218226&action=review

LGTM.

> Source/WebCore/platform/nix/FileSystemNix.cpp:137
> +

Extra blank line here.

> Source/WebCore/platform/nix/FileSystemNix.cpp:155
> +

Ditto.

[Thiago de Barros Lacerda]

Created attachment 218261 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 218261 [details]
Patch for landing

Clearing flags on attachment: 218261

Committed r160001: <http://trac.webkit.org/changeset/160001>