Bug 124975 – Fix a crash in the webaudio source provider when the audio track is going away.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Nick Diego Yamane (diegoyam)]

Consider merging:

https://chromium.googlesource.com/chromium/blink/+/b21838b32bf11b1a972dfc449ddde71115490c23

Before this, it was hitting a use-after-free crash on the renderer when the audio track in the media stream is going away and the webaudio MediaStreamSourceNode is still running.

[Nick Diego Yamane (diegoyam)]

Created attachment 218078 [details]
Patch

[Philippe Normand]

Comment on attachment 218078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218078&action=review

> Source/WebCore/ChangeLog:8
> +        Before this patch, it was hittinh a use-after-free crash  when the audio

Typo: hittinh. Also, I'm not sure it's a common thing to do when merging Blink changes but I think it'd be good to mention the blink commit and its author in the ChangeLog.

[Eric Carlson]

Comment on attachment 218078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218078&action=review

>> Source/WebCore/ChangeLog:8
>> +        Before this patch, it was hittinh a use-after-free crash  when the audio
> 
> Typo: hittinh. Also, I'm not sure it's a common thing to do when merging Blink changes but I think it'd be good to mention the blink commit and its author in the ChangeLog.

Yes, we typically include the Blink commit url and author in the ChangeLog.

[Nick Diego Yamane (diegoyam)]

(In reply to comment #3)
> (From update of attachment 218078 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218078&action=review
> 
> >> Source/WebCore/ChangeLog:8
> >> +        Before this patch, it was hittinh a use-after-free crash  when the audio
> > 
> > Typo: hittinh. Also, I'm not sure it's a common thing to do when merging Blink changes but I think it'd be good to mention the blink commit and its author in the ChangeLog.
> 
> Yes, we typically include the Blink commit url and author in the ChangeLog.

Yeah, you're right about that. I'll upload a patch with those i nformations in the changelog tomorrow.

Thanks

[Nick Diego Yamane (diegoyam)]

Created attachment 218160 [details]
Improved ChangeLog

Updated as per comments from Eric and Philip.

[Philippe Normand]

Comment on attachment 218160 [details]
Improved ChangeLog

Hum sorry the author is missing in the ChangeLog

[Philippe Normand]

Comment on attachment 218160 [details]
Improved ChangeLog

cq+ as other blink merges don't include author either. It can be found on the blink review link anyway.

[WebKit Commit Bot]

Comment on attachment 218160 [details]
Improved ChangeLog

Clearing flags on attachment: 218160

Committed r159931: <http://trac.webkit.org/changeset/159931>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.