Bug 124963 – [CSS Regions] Fix Layout/RegionsSelection.html in Mac platform

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Manuel Rego Casasnovas]

The performance test Layout/RegionsSelection.html introduced in r159488 is not working properly in Mac platform.

In Mac it takes just a few milliseconds to run the test, while in GTK+ and Blink (Linux) it takes more than 1 second (of course depending on the the machine).

It seems that the test actually is not selecting anything due to mouse events being done out of the window dimensions.

I think we should use setBaseAndExtent() to fix this test and in the future if we think it's needed we could add a new test that fits in the window size performing selection using mouse events.

[Manuel Rego Casasnovas]

Created attachment 217987 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 217987 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217987&action=review

> PerformanceTests/Layout/resources/regions.js:95
> +            window.getSelection().setBaseAndExtent(paragraphs[0], 0, paragraphs[i], 0);

setBaseAndExtent is a non-standard API so perhaps we want to use collapse & extend?
Also, we don't need "window.".

[Manuel Rego Casasnovas]

Created attachment 218335 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 218335 [details]
Patch

Clearing flags on attachment: 218335

Committed r160041: <http://trac.webkit.org/changeset/160041>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.