Bug 124963 - [CSS Regions] Fix Layout/RegionsSelection.html in Mac platform
Summary: [CSS Regions] Fix Layout/RegionsSelection.html in Mac platform
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
Depends on:
Blocks: 124281
  Show dependency treegraph
Reported: 2013-11-28 01:55 PST by Manuel Rego Casasnovas
Modified: 2013-12-03 14:32 PST (History)
5 users (show)

See Also:

Patch (2.22 KB, patch)
2013-11-28 01:57 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch (2.28 KB, patch)
2013-12-03 13:42 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2013-11-28 01:55:40 PST
The performance test Layout/RegionsSelection.html introduced in r159488 is not working properly in Mac platform.

In Mac it takes just a few milliseconds to run the test, while in GTK+ and Blink (Linux) it takes more than 1 second (of course depending on the the machine).

It seems that the test actually is not selecting anything due to mouse events being done out of the window dimensions.

I think we should use setBaseAndExtent() to fix this test and in the future if we think it's needed we could add a new test that fits in the window size performing selection using mouse events.
Comment 1 Manuel Rego Casasnovas 2013-11-28 01:57:28 PST
Created attachment 217987 [details]
Comment 2 Ryosuke Niwa 2013-12-03 13:19:37 PST
Comment on attachment 217987 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=217987&action=review

> PerformanceTests/Layout/resources/regions.js:95
> +            window.getSelection().setBaseAndExtent(paragraphs[0], 0, paragraphs[i], 0);

setBaseAndExtent is a non-standard API so perhaps we want to use collapse & extend?
Also, we don't need "window.".
Comment 3 Manuel Rego Casasnovas 2013-12-03 13:42:19 PST
Created attachment 218335 [details]
Comment 4 WebKit Commit Bot 2013-12-03 14:32:31 PST
Comment on attachment 218335 [details]

Clearing flags on attachment: 218335

Committed r160041: <http://trac.webkit.org/changeset/160041>
Comment 5 WebKit Commit Bot 2013-12-03 14:32:33 PST
All reviewed patches have been landed.  Closing bug.