Bug 124961 - Perform some spring cleaning to WKContentView and WKView
Summary: Perform some spring cleaning to WKContentView and WKView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-27 23:26 PST by Sam Weinig
Modified: 2013-11-28 16:38 PST (History)
5 users (show)

See Also:

Attachments
Patch (30.09 KB, patch)
2013-11-27 23:42 PST, Sam Weinig 		mitz: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-11-27 23:26:43 PST 
Perform some spring cleaning to WKContentView and WKView
Comment 1 Sam Weinig 2013-11-27 23:42:31 PST 
Created attachment 217983 [details]
Patch
Comment 2 mitz 2013-11-28 00:08:38 PST 
Comment on attachment 217983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217983&action=review

> Source/WebKit2/UIProcess/API/ios/WKContentView.mm:28
>  #import "WKContentViewInternal.h"
> +#import "WKContentViewPrivate.h"

This shouldn’t be needed. Internal should import Private.

> Source/WebKit2/UIProcess/API/ios/WKContentView.mm:39
> +#import "WKProcessGroupInternal.h"
>  #import "WKProcessGroupPrivate.h"

Private should be imported by Internal.

> Source/WebKit2/UIProcess/API/ios/WKContentView.mm:66
> +    // FIXME: Implement.
> +    return nil;

Should release self before returning nil from an initializer.

> Source/WebKit2/UIProcess/API/ios/WKContentView.mm:72
> -    if (!(self = [super initWithFrame:frame]))
> +    self = [super initWithFrame:frame];
> +    if (!self)

Why?
Comment 3 EFL EWS Bot 2013-11-28 00:26:58 PST 
Comment on attachment 217983 [details]
Patch

Attachment 217983 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/39388002
Comment 4 mitz 2013-11-28 12:33:10 PST 
Comment on attachment 217983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217983&action=review

> Source/WebKit2/UIProcess/API/ios/WKView.mm:28
>  #import "WKView.h"
> +#import "WKViewPrivate.h"

No need for #import "WKView.h"
Comment 5 Sam Weinig 2013-11-28 12:58:29 PST 
Committed r159859: <http://trac.webkit.org/changeset/159859>
Comment 6 Nick Diego Yamane (diegoyam) 2013-11-28 16:38:07 PST 
Bug to fix gtk build: https://bugs.webkit.org/show_bug.cgi?id=124992