Bug 124955 - Give the PageClient a chance to handle geolocation permission requests if the UIClient doesn't handle it
Summary: Give the PageClient a chance to handle geolocation permission requests if the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-27 20:12 PST by Sam Weinig
Modified: 2013-11-27 20:31 PST (History)
0 users

See Also:


Attachments
Patch (9.29 KB, patch)
2013-11-27 20:15 PST, Sam Weinig
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-11-27 20:12:19 PST
Give the PageClient a chance to handle geolocation permission requests if the UIClient doesn't handle it
Comment 1 Sam Weinig 2013-11-27 20:15:32 PST
Created attachment 217975 [details]
Patch
Comment 2 mitz 2013-11-27 20:22:10 PST
Comment on attachment 217975 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217975&action=review

> Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h:60
> +    virtual bool decidePolicyForGeolocationPermissionRequest(WebFrameProxy*, WebSecurityOrigin*, GeolocationPermissionRequestProxy*);

I think the parameters can be references and the function can be annotated as an override.
Comment 3 Sam Weinig 2013-11-27 20:31:28 PST
Committed r159833: <http://trac.webkit.org/changeset/159833>