WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
124955
Give the PageClient a chance to handle geolocation permission requests if the UIClient doesn't handle it
https://bugs.webkit.org/show_bug.cgi?id=124955
Summary
Give the PageClient a chance to handle geolocation permission requests if the...
Sam Weinig
Reported
2013-11-27 20:12:19 PST
Give the PageClient a chance to handle geolocation permission requests if the UIClient doesn't handle it
Attachments
Patch
(9.29 KB, patch)
2013-11-27 20:15 PST
,
Sam Weinig
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2013-11-27 20:15:32 PST
Created
attachment 217975
[details]
Patch
mitz
Comment 2
2013-11-27 20:22:10 PST
Comment on
attachment 217975
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=217975&action=review
> Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h:60 > + virtual bool decidePolicyForGeolocationPermissionRequest(WebFrameProxy*, WebSecurityOrigin*, GeolocationPermissionRequestProxy*);
I think the parameters can be references and the function can be annotated as an override.
Sam Weinig
Comment 3
2013-11-27 20:31:28 PST
Committed
r159833
: <
http://trac.webkit.org/changeset/159833
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug