Bug 124948 – Make WKBrowsingContextGroup work with WKObject wrapping

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Make WKBrowsingContextGroup work with WKObject wrapping

[Sam Weinig]

Created attachment 217966 [details]
Patch

[WebKit Commit Bot]

Attachment 217966 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/APIObject.h', u'Source/WebKit2/Shared/Cocoa/APIObject.mm', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupInternal.h', u'Source/WebKit2/UIProcess/WebPageGroup.cpp', u'Source/WebKit2/UIProcess/WebPageGroup.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
Source/WebKit2/Shared/APIObject.h:173:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 217966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217966&action=review

> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm:30
>  #if WK_API_ENABLED

Can we remove some of the following imports, now that we don’t use C SPI here?

> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm:56
> +#pragma mark WKObject protocol implementation
> +
> +- (API::Object&)_apiObject
> +{
> +    return *reinterpret_cast<API::Object*>(&_pageGroup);
> +}
> +

I’d stick this at the bottom (then it’s also clear that the following methods aren’t part of WKObject conformance. Or use “#pragma mark -” to separate the rest.

[Sam Weinig]

Committed r159824: <http://trac.webkit.org/changeset/159824>