Bug 124948 - Make WKBrowsingContextGroup work with WKObject wrapping
Summary: Make WKBrowsingContextGroup work with WKObject wrapping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-27 13:24 PST by Sam Weinig
Modified: 2013-11-27 14:45 PST (History)
1 user (show)

See Also:


Attachments
Patch (18.72 KB, patch)
2013-11-27 13:32 PST, Sam Weinig
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-11-27 13:24:26 PST
Make WKBrowsingContextGroup work with WKObject wrapping
Comment 1 Sam Weinig 2013-11-27 13:32:10 PST
Created attachment 217966 [details]
Patch
Comment 2 WebKit Commit Bot 2013-11-27 13:33:58 PST
Attachment 217966 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/APIObject.h', u'Source/WebKit2/Shared/Cocoa/APIObject.mm', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupInternal.h', u'Source/WebKit2/UIProcess/WebPageGroup.cpp', u'Source/WebKit2/UIProcess/WebPageGroup.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
Source/WebKit2/Shared/APIObject.h:173:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2013-11-27 13:39:51 PST
Comment on attachment 217966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217966&action=review

> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm:30
>  #if WK_API_ENABLED

Can we remove some of the following imports, now that we don’t use C SPI here?

> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm:56
> +#pragma mark WKObject protocol implementation
> +
> +- (API::Object&)_apiObject
> +{
> +    return *reinterpret_cast<API::Object*>(&_pageGroup);
> +}
> +

I’d stick this at the bottom (then it’s also clear that the following methods aren’t part of WKObject conformance. Or use “#pragma mark -” to separate the rest.
Comment 4 Sam Weinig 2013-11-27 14:45:52 PST
Committed r159824: <http://trac.webkit.org/changeset/159824>