Bug 124936 - moveDoubleToInts should be used in SpecializedThunkJIT::returnDouble
Summary: moveDoubleToInts should be used in SpecializedThunkJIT::returnDouble
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-27 06:11 PST by Julien Brianceau
Modified: 2013-11-29 09:23 PST (History)
7 users (show)

See Also:

Attachments
Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for JSVALUE32_64 ports. (1.76 KB, patch)
2013-11-27 06:13 PST, Julien Brianceau 		no flags Details | Formatted Diff | Diff
Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports. (1.98 KB, patch)
2013-11-29 08:24 PST, Julien Brianceau 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-11-27 06:11:36 PST 
In current SpecializedThunkJIT::returnDouble of JSVALUE32_64 ports, moveDoubleToInts function from macro assembler is likely to be more efficient than the current generic implementation using the stack.
Comment 1 Julien Brianceau 2013-11-27 06:13:08 PST 
Created attachment 217946 [details]
Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for JSVALUE32_64 ports.
Comment 2 Zoltan Herczeg 2013-11-29 06:34:15 PST 
I suspect the point of the original code to avoid changing of src, which is returned by returnDouble(...). We might need to keep the original code path on x86.
Comment 3 Julien Brianceau 2013-11-29 06:38:59 PST 
(In reply to comment #2)
> I suspect the point of the original code to avoid changing of src, which is returned by returnDouble(...). We might need to keep the original code path on x86.
You're right, I didn't see that, thanks.
I'm going to check all 32-bit architectures moveDoubleToInts then submit a new patch with #if CPU(xx) condition.
Comment 4 Julien Brianceau 2013-11-29 08:24:44 PST 
Created attachment 218068 [details]
Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports.
Comment 5 Zoltan Herczeg 2013-11-29 08:56:24 PST 
Comment on attachment 218068 [details]
Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports.

nice patch. r=me
Comment 6 WebKit Commit Bot 2013-11-29 09:23:18 PST 
Comment on attachment 218068 [details]
Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports.

Clearing flags on attachment: 218068

Committed r159873: <http://trac.webkit.org/changeset/159873>
Comment 7 WebKit Commit Bot 2013-11-29 09:23:21 PST 
All reviewed patches have been landed.  Closing bug.