Bug 124930 - Building EFL Webkit again with mediastream enabled
Summary: Building EFL Webkit again with mediastream enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago de Barros Lacerda
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-27 05:28 PST by Thiago de Barros Lacerda
Modified: 2013-11-28 11:30 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.52 KB, patch)
2013-11-27 05:32 PST, Thiago de Barros Lacerda 		no flags Details | Formatted Diff | Diff
Patch (1.44 KB, patch)
2013-11-28 10:21 PST, Thiago de Barros Lacerda 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago de Barros Lacerda 2013-11-27 05:28:21 PST 
Adding missing includes to CMakeLists.txt
Comment 1 Thiago de Barros Lacerda 2013-11-27 05:32:05 PST 
Created attachment 217944 [details]
Patch
Comment 2 Gyuyoung Kim 2013-11-27 05:41:22 PST 
Comment on attachment 217944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217944&action=review

> Source/WebKit/ChangeLog:3
> +        Building EFL Webkit again

It looks this title is a little ambiguous. Is there any build break on EFL WK1 now ?
Comment 3 Thiago de Barros Lacerda 2013-11-27 05:44:28 PST 
(In reply to comment #2)
> (From update of attachment 217944 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217944&action=review
> 
> > Source/WebKit/ChangeLog:3
> > +        Building EFL Webkit again
> 
> It looks this title is a little ambiguous. Is there any build break on EFL WK1 now ?

Yes, with mediastream enabled. EFL bots are not enabling it by default
I will change the title of the bug
Comment 4 Thiago de Barros Lacerda 2013-11-28 10:21:10 PST 
Created attachment 218011 [details]
Patch
Comment 5 WebKit Commit Bot 2013-11-28 11:30:49 PST 
Comment on attachment 218011 [details]
Patch

Clearing flags on attachment: 218011

Committed r159852: <http://trac.webkit.org/changeset/159852>
Comment 6 WebKit Commit Bot 2013-11-28 11:30:51 PST 
All reviewed patches have been landed.  Closing bug.