Bug 124923 - [ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
Summary: [ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-27 03:22 PST by Krzysztof Czech
Modified: 2013-11-29 03:35 PST (History)
10 users (show)

See Also:

Attachments
patch (7.35 KB, patch)
2013-11-27 03:32 PST, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
patch (7.34 KB, patch)
2013-11-27 03:41 PST, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Czech 2013-11-27 03:22:51 PST 
I think ATK states, more precisely ATK_STATE_EDITABLE could be used to check whether attribute/element is settable.
Comment 1 Krzysztof Czech 2013-11-27 03:32:14 PST 
Created attachment 217936 [details]
patch
Comment 2 WebKit Commit Bot 2013-11-27 03:33:53 PST 
Attachment 217936 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/accessibility/content-editable-expected.txt', u'LayoutTests/accessibility/content-editable.html', u'LayoutTests/platform/mac/accessibility/content-editable-expected.txt', u'LayoutTests/platform/mac/accessibility/content-editable.html', u'Tools/ChangeLog', u'Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp', u'Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp']" exit_code: 1
Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:765:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Krzysztof Czech 2013-11-27 03:41:46 PST 
Created attachment 217937 [details]
patch
Comment 4 WebKit Commit Bot 2013-11-29 03:35:38 PST 
Comment on attachment 217937 [details]
patch

Clearing flags on attachment: 217937

Committed r159867: <http://trac.webkit.org/changeset/159867>
Comment 5 WebKit Commit Bot 2013-11-29 03:35:40 PST 
All reviewed patches have been landed.  Closing bug.