Bug 124920 - Build warnings in DownloadAuthenticationClient.cpp
Summary: Build warnings in DownloadAuthenticationClient.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-27 02:42 PST by Tamas Gergely
Modified: 2013-12-04 11:42 PST (History)
6 users (show)

See Also:

Attachments
Fix build warnings (2.19 KB, patch)
2013-11-27 02:47 PST, Tamas Gergely 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Gergely 2013-11-27 02:42:29 PST 
There are build warnings in DownloadAuthenticationClient.cpp since r159441.
Comment 1 Tamas Gergely 2013-11-27 02:47:11 PST 
Created attachment 217933 [details]
Fix build warnings
Comment 2 Alexey Proskuryakov 2013-12-04 10:06:07 PST 
It's unfortunate that some ports enable unused argument warnings in WebKit2, and others don't. I remember way too many patches to fix build breakage on ports that do.
Comment 3 WebKit Commit Bot 2013-12-04 10:32:51 PST 
Comment on attachment 217933 [details]
Fix build warnings

Clearing flags on attachment: 217933

Committed r160101: <http://trac.webkit.org/changeset/160101>
Comment 4 WebKit Commit Bot 2013-12-04 10:32:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2013-12-04 11:42:43 PST 
Are these warnings off on the Mac port because of Objective-C?