Bug 124902 – Adding MediaConstraintsMock class

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Thiago de Barros Lacerda]

Missing block to run RTCPeerConnection LayoutTests

[Thiago de Barros Lacerda]

Created attachment 217907 [details]
Patch

[Thiago de Barros Lacerda]

*** Bug 123093 has been marked as a duplicate of this bug. ***

[Eric Carlson]

Comment on attachment 217907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217907&action=review

> Source/WebCore/platform/mock/MediaConstraintsMock.cpp:52
> +bool isSupported(const String& constraint)
> +{
> +    return constraint == "valid_and_supported_1" || constraint == "valid_and_supported_2";
> +}
> +
> +bool isValid(const String& constraint)
> +{
> +    return isSupported(constraint) || constraint == "valid_but_unsupported_1" || constraint == "valid_but_unsupported_2";
> +}
> +
> +bool MediaConstraintsMock::verifyConstraints(PassRefPtr<MediaConstraints> prpConstraints)

This duplicates functionality in MockMediaStreamCenter. I would rather you use MockMediaStreamCenter::validateRequestConstraints and its supporting functions, and have MockMediaStreamCenter use this.

[Thiago de Barros Lacerda]

(In reply to comment #3)
> (From update of attachment 217907 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217907&action=review
> 
> > Source/WebCore/platform/mock/MediaConstraintsMock.cpp:52
> > +bool isSupported(const String& constraint)
> > +{
> > +    return constraint == "valid_and_supported_1" || constraint == "valid_and_supported_2";
> > +}
> > +
> > +bool isValid(const String& constraint)
> > +{
> > +    return isSupported(constraint) || constraint == "valid_but_unsupported_1" || constraint == "valid_but_unsupported_2";
> > +}
> > +
> > +bool MediaConstraintsMock::verifyConstraints(PassRefPtr<MediaConstraints> prpConstraints)
> 
> This duplicates functionality in MockMediaStreamCenter. I would rather you use MockMediaStreamCenter::validateRequestConstraints and its supporting functions, and have MockMediaStreamCenter use this.

I agree, haven't seen that MockMediaStreamCenter was validating constraints too.

[Thiago de Barros Lacerda]

Created attachment 217945 [details]
Patch

[Eric Carlson]

Comment on attachment 217945 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217945&action=review

> Source/WebCore/ChangeLog:8
> +        Missing block to run RTCPeerConnection LayoutTests

Not: do you mean missing *mock*?

> Source/WebCore/platform/mock/MediaConstraintsMock.cpp:2
> + * Copyright (C) 2012 Google Inc. All rights reserved.

Nit: I think you can replace "Google" with "Apple" here.

> Source/WebCore/platform/mock/MediaConstraintsMock.h:2
> + * Copyright (C) 2012 Google Inc. All rights reserved.

Ditto

> Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.cpp:52
> +    if (invalidQuery.isEmpty()) {

Nit: you could use an early return here.

[Thiago de Barros Lacerda]

Created attachment 217961 [details]
Patch for landing.

[Thiago de Barros Lacerda]

Created attachment 217962 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 217962 [details]
Patch for landing.

Clearing flags on attachment: 217962

Committed r159823: <http://trac.webkit.org/changeset/159823>