RESOLVED FIXED 124899
[cmake] Fix cmake warning: Argument not separated from preceding token by whitespace 
https://bugs.webkit.org/show_bug.cgi?id=124899
Summary [cmake] Fix cmake warning: Argument not separated from preceding token by whi...
Laszlo Vidacs
Reported 2013-11-26 13:20:20 PST
Fix cmake (v2.8.11+) warnings like: CMake Warning (dev) at Source/cmake/OptionsEfl.cmake:172 (find_package): Syntax Warning in cmake code at /home/elecro/work/webkit/WebKit/Source/cmake/FindGStreamer.cmake:97:45 Argument not separated from preceding token by whitespace. Call Stack (most recent call first): CMakeLists.txt:137 (include) This warning is for project developers. Use -Wno-dev to suppress it.
Attachments
Patch (1.94 KB, patch)
2013-11-26 14:12 PST, Laszlo Vidacs 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Vidacs
Comment 1 2013-11-26 14:12:09 PST
Created attachment 217900 [details] Patch
Peter Gal
Comment 2 2013-11-28 00:18:56 PST
LGTM (sadly I'm not a reviewer :( )
Ryuan Choi
Comment 3 2013-11-28 00:23:28 PST
Comment on attachment 217900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217900&action=review > Source/cmake/FindGStreamer.cmake:97 > - message(FATAL_ERROR "Required version ("${GStreamer_FIND_VERSION}") is higher than found version ("${GSTREAMER_VERSION}")") > + message(FATAL_ERROR "Required version (" ${GStreamer_FIND_VERSION} ") is higher than found version (" ${GSTREAMER_VERSION} ")") Just removing " is also fine.
WebKit Commit Bot
Comment 4 2013-11-29 02:49:09 PST
Comment on attachment 217900 [details] Patch Clearing flags on attachment: 217900 Committed r159866: <http://trac.webkit.org/changeset/159866>
WebKit Commit Bot
Comment 5 2013-11-29 02:49:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.