Bug 124889 – Move methods which belong to Checkout

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Dániel Bátyai]

Moved methods which belong to Checkout into checkout.py

FIXME: This belongs in Checkout, not SCM.
def scripts_directory(self):
FIXME: This belongs in Checkout, not SCM.
def script_path(self, script_name):

[Dániel Bátyai]

Created attachment 217878 [details]
Proposed patch

[Ryosuke Niwa]

Comment on attachment 217878 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217878&action=review

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:276
> -        return self.run([self.script_path("svn-create-patch")] + changed_files,
> +        script_path = self._filesystem.join(self.checkout_root, "Tools", "Scripts", "svn-create-patch")
> +        return self.run([script_path] + changed_files,

Why are we not moving this method to Checkout?

[Dániel Bátyai]

(In reply to comment #2)
> Why are we not moving this method to Checkout?

Because the method form the supercalss is called, and if I moved it, I'd have to move it from both SVN and Git, but then I would also have to figure out somehow which one to call, since it's not obvius from the superclass, and that would just be a huge hack, unless I'm missing something.

[WebKit Commit Bot]

Comment on attachment 217878 [details]
Proposed patch

Clearing flags on attachment: 217878

Committed r159796: <http://trac.webkit.org/changeset/159796>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.