Bug 124888 - [GTK] Enable web audio by default
Summary: [GTK] Enable web audio by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-26 06:52 PST by Alberto Garcia
Modified: 2013-12-06 03:05 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.35 KB, patch)
2013-11-26 06:53 PST, Alberto Garcia 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-11-26 06:52:02 PST 
When building with ./configure, enable_web_audio defaults to "no".

However the basic functionality has been working for months so it's safe to enable it now.
Comment 1 Alberto Garcia 2013-11-26 06:53:14 PST 
Created attachment 217877 [details]
Patch
Comment 2 Martin Robinson 2013-11-26 06:53:32 PST 
How is test coverage?
Comment 3 Martin Robinson 2013-11-26 06:54:07 PST 
We should probably get some rough consensus to ship this feature. How is test coverage?
Comment 4 Philippe Normand 2013-11-26 07:00:00 PST 
Most webaudio tests pass. Currently flagged:

webkit.org/b/79203 webaudio/mediastreamaudiodestinationnode.html [ Skip ]
webkit.org/b/79203 webaudio/mediastreamaudiosourcenode.html [ Skip ]
webkit.org/b/105296 webaudio/delaynode-max-nondefault-delay.html [ Failure ]
webkit.org/b/105296 webaudio/delaynode-maxdelay.html [ Failure ]
webkit.org/b/105296 webaudio/delaynode-scheduling.html [ Failure ]
webkit.org/b/105299 webaudio/javascriptaudionode.html [ Failure ]
Comment 5 Philippe Normand 2013-11-26 07:12:26 PST 
I think it's safe to ship it... Moreover the enable-webaudio setting is off by default, so in the end it's up to the application developer to enable it or not.
Comment 6 Philippe Normand 2013-11-28 23:27:14 PST 
Adding Carlos and Gustavo.

What do you think about enabling WebAudio by default?
Comment 7 Carlos Garcia Campos 2013-11-28 23:50:26 PST 
(In reply to comment #6)
> Adding Carlos and Gustavo.
> 
> What do you think about enabling WebAudio by default?

I don't see why not
Comment 8 Gustavo Noronha (kov) 2013-11-29 09:15:11 PST 
+1 from me
Comment 9 Alberto Garcia 2013-12-06 03:05:23 PST 
Committed r160215: <http://trac.webkit.org/changeset/160215>