Bug 124888 – [GTK] Enable web audio by default

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alberto Garcia]

When building with ./configure, enable_web_audio defaults to "no".

However the basic functionality has been working for months so it's safe to enable it now.

[Alberto Garcia]

Created attachment 217877 [details]
Patch

[Martin Robinson]

How is test coverage?

[Martin Robinson]

We should probably get some rough consensus to ship this feature. How is test coverage?

[Philippe Normand]

Most webaudio tests pass. Currently flagged:

webkit.org/b/79203 webaudio/mediastreamaudiodestinationnode.html [ Skip ]
webkit.org/b/79203 webaudio/mediastreamaudiosourcenode.html [ Skip ]
webkit.org/b/105296 webaudio/delaynode-max-nondefault-delay.html [ Failure ]
webkit.org/b/105296 webaudio/delaynode-maxdelay.html [ Failure ]
webkit.org/b/105296 webaudio/delaynode-scheduling.html [ Failure ]
webkit.org/b/105299 webaudio/javascriptaudionode.html [ Failure ]

[Philippe Normand]

I think it's safe to ship it... Moreover the enable-webaudio setting is off by default, so in the end it's up to the application developer to enable it or not.

[Philippe Normand]

Adding Carlos and Gustavo.

What do you think about enabling WebAudio by default?

[Carlos Garcia Campos]

(In reply to comment #6)
> Adding Carlos and Gustavo.
> 
> What do you think about enabling WebAudio by default?

I don't see why not

[Gustavo Noronha (kov)]

+1 from me

[Alberto Garcia]

Committed r160215: <http://trac.webkit.org/changeset/160215>