Bug 124879 – [EFL] Layout tests need to be rebaselined.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Jongwoo Choi]

fast/table/011.html
fast/table/border-collapsing/004.html
fast/table/tableInsideCaption.html

Above tests need to be rebaselined results after r159747.

[Jongwoo Choi]

Created attachment 217856 [details]
Patch

[Grzegorz Czajkowski]

Comment on attachment 217856 [details]
Patch

Those tests definitely need to be rebaselined. Could you take care of png files as well? Those have been added at r140159 and it seems to be out of date. In addition, r159747 rebaselines more tests (at least for mac), don't we need to update them? Thanks

[Michal Pakula vel Rutka]

(In reply to comment #2)
> (From update of attachment 217856 [details])
> Those tests definitely need to be rebaselined. Could you take care of png files as well? Those have been added at r140159 and it seems to be out of date. In addition, r159747 rebaselines more tests (at least for mac), don't we need to update them? Thanks

The rests of tests were updated in r159753 and r159755.

The only test here which needs pixel expectation update is fast/table/border-collapsing/004.html, but the difference is not caused by r159747.
The difference is lack of scrollbar in current output and it is started to happen after r156472, precisely this change: http://trac.webkit.org/changeset/156472/trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp @2547. This affects not only this test but around 300-400 other ones causing identical image failures (lack of scrollbars in pixel expectations). 
I think we should leave old pixel expectation even if it is incorrect, in this and other tests and fix the bug with scrollbars.

[Jongwoo Choi]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 217856 [details] [details])
> > Those tests definitely need to be rebaselined. Could you take care of png files as well? Those have been added at r140159 and it seems to be out of date. In addition, r159747 rebaselines more tests (at least for mac), don't we need to update them? Thanks
> 
> The rests of tests were updated in r159753 and r159755.
> 
> The only test here which needs pixel expectation update is fast/table/border-collapsing/004.html, but the difference is not caused by r159747.
> The difference is lack of scrollbar in current output and it is started to happen after r156472, precisely this change: http://trac.webkit.org/changeset/156472/trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp @2547. This affects not only this test but around 300-400 other ones causing identical image failures (lack of scrollbars in pixel expectations). 
> I think we should leave old pixel expectation even if it is incorrect, in this and other tests and fix the bug with scrollbars.

Thank you for your comment.
I exclude two test expectations(fast/table/011.html and fast/table/tableInsideCaption.html) in this patch.

[Jongwoo Choi]

Created attachment 217910 [details]
Patch

[Jongwoo Choi]

According to Michal Pakula vel Rutka's messages, my first patch was ok.
So, I reupload my first patch.

[Jongwoo Choi]

Created attachment 217971 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 217971 [details]
Patch

Rejecting attachment 217971 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 217971 [details]
Patch

Clearing flags on attachment: 217971

Committed r159841: <http://trac.webkit.org/changeset/159841>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.