Bug 124874 - Remote Layer Tree: Support cloning layers
Summary: Remote Layer Tree: Support cloning layers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-11-25 17:23 PST by Tim Horton
Modified: 2013-12-02 14:40 PST (History)
3 users (show)

See Also:


Attachments
patch (7.76 KB, patch)
2013-11-25 17:30 PST, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff
fix comments except cast (12.09 KB, patch)
2013-12-02 14:25 PST, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-11-25 17:23:20 PST
For reflections, etc.

<rdar://problem/15349468>
Comment 1 Tim Horton 2013-11-25 17:30:32 PST
Created attachment 217852 [details]
patch
Comment 2 Simon Fraser (smfr) 2013-12-02 11:24:37 PST
Comment on attachment 217852 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217852&action=review

Does the right cleanup happen when a mask layer is removed?

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:102
> +    clone->m_properties.notePropertiesChanged(static_cast<RemoteLayerTreeTransaction::LayerChange>(m_properties.everChangedProperties & ~RemoteLayerTreeTransaction::BackingStoreChanged));

Ugly cast :(

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:276
> +    m_maskLayer = toPlatformCALayerRemote(layer);

Can we call the field m_maskLayerID please? (Same with other LayerID fields).
Comment 3 Tim Horton 2013-12-02 14:25:07 PST
Created attachment 218215 [details]
fix comments except cast
Comment 4 Tim Horton 2013-12-02 14:40:00 PST
http://trac.webkit.org/changeset/159967