Bug 124873 - Don't parent the TileController root layer in two places
Summary: Don't parent the TileController root layer in two places
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-25 17:18 PST by Tim Horton
Modified: 2013-11-26 19:47 PST (History)
4 users (show)

See Also:


Attachments
patch (1.36 KB, patch)
2013-11-25 17:20 PST, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-11-25 17:18:26 PST
The TileController root layer gets parented both directly and as a "custom" sublayer of its owning layer.

We don't need to parent it directly, only the custom sublayer mechanism was intended to be used (so that they'll stay put in the layer hierarchy).
Comment 1 Tim Horton 2013-11-25 17:20:45 PST
Created attachment 217850 [details]
patch
Comment 2 Brent Fulgham 2013-11-26 19:19:45 PST
Comment on attachment 217850 [details]
patch

r=me. Parenting yourself is gross!  Gross I say!
Comment 3 WebKit Commit Bot 2013-11-26 19:47:35 PST
Comment on attachment 217850 [details]
patch

Clearing flags on attachment: 217850

Committed r159800: <http://trac.webkit.org/changeset/159800>
Comment 4 WebKit Commit Bot 2013-11-26 19:47:36 PST
All reviewed patches have been landed.  Closing bug.