Bug 124871 – [WebGL] Implement OES texture float linear

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Dean Jackson]

This demo was passed around last week: http://www.cake23.de/fmx/turing-fluid-particle-projection-feedback.html
WebKit gets a warning saying we don't implement OES_texture_float_linear.

[Dean Jackson]

<rdar://problem/15548220
>

[Dean Jackson]

<rdar://problem/15548220>

(not sure what is up with the tool that adds this with an extra newline)

[Dean Jackson]

I've got the web facing bits done. Just need to make sure we actually use the right code in the implementation.

[Dean Jackson]

Renaming this to only be about enabling float linear, and not yet half float linear, which will depend on 110936

[Dean Jackson]

Created attachment 218139 [details]
Patch

[WebKit Commit Bot]

Attachment 218139 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/canvas/webgl/oes-texture-float-linear.html', u'LayoutTests/fast/canvas/webgl/resources/oes-texture-float-and-half-float-linear.js', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp', u'Source/WebCore/html/canvas/OESTextureFloatLinear.cpp', u'Source/WebCore/html/canvas/OESTextureFloatLinear.h', u'Source/WebCore/html/canvas/OESTextureFloatLinear.idl', u'Source/WebCore/html/canvas/WebGLExtension.h', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.h', u'Source/WebCore/html/canvas/WebGLTexture.cpp', u'Source/WebCore/html/canvas/WebGLTexture.h', u'Source/WebCore/platform/graphics/Extensions3D.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp']" exit_code: 1
Source/WebCore/html/canvas/OESTextureFloatLinear.cpp:30:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 218139 [details]
Patch

Attachment 218139 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/41718007

[EFL EWS Bot]

Comment on attachment 218139 [details]
Patch

Attachment 218139 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/40008280

[Dean Jackson]

Created attachment 218140 [details]
Patch

[WebKit Commit Bot]

Attachment 218140 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/canvas/webgl/oes-texture-float-linear.html', u'LayoutTests/fast/canvas/webgl/resources/oes-texture-float-and-half-float-linear.js', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp', u'Source/WebCore/html/canvas/OESTextureFloatLinear.cpp', u'Source/WebCore/html/canvas/OESTextureFloatLinear.h', u'Source/WebCore/html/canvas/OESTextureFloatLinear.idl', u'Source/WebCore/html/canvas/WebGLExtension.h', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.h', u'Source/WebCore/html/canvas/WebGLTexture.cpp', u'Source/WebCore/html/canvas/WebGLTexture.h', u'Source/WebCore/platform/graphics/Extensions3D.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp']" exit_code: 1
Source/WebCore/html/canvas/OESTextureFloatLinear.cpp:30:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 218140 [details]
Patch

Attachment 218140 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/41648016

[EFL EWS Bot]

Comment on attachment 218140 [details]
Patch

Attachment 218140 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/39908274

[kov's GTK+ EWS bot]

Comment on attachment 218140 [details]
Patch

Attachment 218140 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/41648017

[Dean Jackson]

Created attachment 218141 [details]
Patch

[WebKit Commit Bot]

Attachment 218141 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/canvas/webgl/oes-texture-float-linear-expected.txt', u'LayoutTests/fast/canvas/webgl/oes-texture-float-linear.html', u'LayoutTests/fast/canvas/webgl/resources/oes-texture-float-and-half-float-linear.js', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp', u'Source/WebCore/html/canvas/OESTextureFloatLinear.cpp', u'Source/WebCore/html/canvas/OESTextureFloatLinear.h', u'Source/WebCore/html/canvas/OESTextureFloatLinear.idl', u'Source/WebCore/html/canvas/WebGLExtension.h', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.h', u'Source/WebCore/html/canvas/WebGLTexture.cpp', u'Source/WebCore/html/canvas/WebGLTexture.h', u'Source/WebCore/platform/graphics/Extensions3D.h', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp']" exit_code: 1
Source/WebCore/html/canvas/OESTextureFloatLinear.cpp:30:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 218141 [details]
Patch

Attachment 218141 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/41718014

[kov's GTK+ EWS bot]

Comment on attachment 218141 [details]
Patch

Attachment 218141 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/41268018

[EFL EWS Bot]

Comment on attachment 218141 [details]
Patch

Attachment 218141 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/41698012

[Dean Jackson]

Created attachment 218306 [details]
Patch

[EFL EWS Bot]

Comment on attachment 218306 [details]
Patch

Attachment 218306 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/39358321

[Dean Jackson]

Created attachment 218309 [details]
Patch

[EFL EWS Bot]

Comment on attachment 218309 [details]
Patch

Attachment 218309 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/42108154

[Dean Jackson]

Created attachment 218312 [details]
Patch

[Brent Fulgham]

Comment on attachment 218312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218312&action=review

r=me.

> Source/WebCore/html/canvas/WebGLRenderingContext.h:564
> +    void checkTextureCompleteness(const char*, bool);

I like this name change!

> Source/WebCore/html/canvas/WebGLTexture.cpp:369
> +        m_isFloatType = m_info[0][0].type == GraphicsContext3D::FLOAT;

:-(

[Dean Jackson]

Committed r160030: <http://trac.webkit.org/changeset/160030>

[Brent Fulgham]

*** Bug 109853 has been marked as a duplicate of this bug. ***