Bug 12487 - REGRESSION: Repro crash when a second background image is animated
Summary: REGRESSION: Repro crash when a second background image is animated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Major
Assignee: Nobody
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2007-01-30 14:01 PST by mitz
Modified: 2007-01-30 15:21 PST (History)
0 users

See Also:


Attachments
Test case (will crash when closed) (336 bytes, text/html)
2007-01-30 14:02 PST, mitz
no flags Details
Deref() all background images and the border image (7.58 KB, patch)
2007-01-30 14:48 PST, mitz
darin: review+
Details | Formatted Diff | Diff
Landable version (7.67 KB, patch)
2007-01-30 15:07 PST, mitz
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2007-01-30 14:01:19 PST
I noticed that RenderObject registers as a client of all its background images but unregisters only from the first one. This makes it leak, and in the case of an animated image, also crash (since the image tries to notified the deleted object of changes). Test case coming up.
Comment 1 mitz 2007-01-30 14:02:35 PST
Created attachment 12811 [details]
Test case (will crash when closed)
Comment 2 mitz 2007-01-30 14:48:39 PST
Created attachment 12813 [details]
Deref() all background images and the border image
Comment 3 Darin Adler 2007-01-30 15:01:13 PST
Comment on attachment 12813 [details]
Deref() all background images and the border image

r=me

+            if (CachedImage* backgroundImage = bgLayer->backgroundImage())
+            backgroundImage->deref(this);

Indented wrong -- needs more spaces.
Comment 4 mitz 2007-01-30 15:07:33 PST
Created attachment 12814 [details]
Landable version

Fixed wrong directory name and indentation (and braces).
Comment 5 Sam Weinig 2007-01-30 15:21:48 PST
Landed in r19273.