Bug 124863 - mediaControlsUserAgentStyleSheet not defined on Windows
Summary: mediaControlsUserAgentStyleSheet not defined on Windows
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 8
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-25 15:02 PST by Alex Christensen
Modified: 2013-12-17 11:16 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.74 KB, patch)
2013-11-25 15:03 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.76 KB, patch)
2013-12-16 20:05 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.76 KB, patch)
2013-12-16 20:28 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-11-25 15:02:05 PST 
I'm not sure where the definition for mediaControlsUserAgentStyleSheet is, but it's causing compile errors with GStreamer on Windows since http://trac.webkit.org/changeset/156546

I assume it's part of CA.  This makes it compile, but I have no idea what this code is doing.
Comment 1 Alex Christensen 2013-11-25 15:03:47 PST 
Created attachment 217836 [details]
Patch
Comment 2 Jer Noble 2013-11-26 08:00:19 PST 
Comment on attachment 217836 [details]
Patch

CA is the wrong protector. This should be #if ENABLE(MEDIA_CONTROLS_SCRIPT).
Comment 3 Alex Christensen 2013-12-16 20:05:00 PST 
Created attachment 219388 [details]
Patch
Comment 4 Alex Christensen 2013-12-16 20:18:32 PST 
Are you sure this shouldn't be #if ENABLE(VIDEO_TRACK) ?
Comment 5 Alex Christensen 2013-12-16 20:28:56 PST 
Created attachment 219391 [details]
Patch
Comment 6 Alex Christensen 2013-12-17 10:31:47 PST 
This isn't causing me a problem anymore because I'm only compiling this code with MEDIA_CONTROLS_SCRIPT and VIDEO_TRACK enabled.