Bug 124857 - RenderTableSection Blink merge asserting
Summary: RenderTableSection Blink merge asserting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords: LayoutTestFailure, MakingBotsRed
Depends on:
Blocks:
 
Reported: 2013-11-25 13:29 PST by Dean Jackson
Modified: 2013-11-28 09:38 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.43 KB, patch)
2013-11-28 09:19 PST, Laszlo Vidacs
no flags Details | Formatted Diff | Diff
Patch (2.77 KB, patch)
2013-11-28 09:31 PST, Laszlo Vidacs
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-11-25 13:29:52 PST
https://bugs.webkit.org/show_bug.cgi?id=20040 has caused two tests to crash, at least on Mountain Lion

tables/mozilla/bugs/bug46268-3.html
tables/mozilla_expected_failures/bugs/bug46268-4.html

http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r159753%20(14410)/results.html
Comment 1 Dean Jackson 2013-11-25 13:34:01 PST
Skipped in https://trac.webkit.org/r159763
Comment 2 Csaba Osztrogonác 2013-11-25 13:56:15 PST
Ouch, sorry for the trouble. Unfortunately we haven't noticed it in time
because of broken debug tester bots (https://bugs.webkit.org/show_bug.cgi?id=124845)

We'll check this regression soon.
Comment 3 Laszlo Vidacs 2013-11-28 09:19:42 PST
Created attachment 218004 [details]
Patch
Comment 4 Laszlo Vidacs 2013-11-28 09:31:13 PST
Created attachment 218006 [details]
Patch
Comment 5 Csaba Osztrogonác 2013-11-28 09:36:42 PST
Comment on attachment 218006 [details]
Patch

Good catch, r=me. Unfortunately we need a massive rebaseline again, but the bug will be really fixed.
Comment 6 Csaba Osztrogonác 2013-11-28 09:38:24 PST
Comment on attachment 218006 [details]
Patch

Clearing flags on attachment: 218006

Committed r159848: <http://trac.webkit.org/changeset/159848>
Comment 7 Csaba Osztrogonác 2013-11-28 09:38:30 PST
All reviewed patches have been landed.  Closing bug.