RESOLVED FIXED 124840
test-webkit-scripts should show the failing tests and use an appropriate exit code 
https://bugs.webkit.org/show_bug.cgi?id=124840
Summary test-webkit-scripts should show the failing tests and use an appropriate exit...
Berta József
Reported 2013-11-25 05:24:20 PST
Display a cumulative indication of success or failure. In addition, call sys.exit() with 0 or 1 depending on that cumulative success or failure.
Attachments
The script now indicates the results, and calls sys.exit() (2.88 KB, patch)
2013-11-25 05:31 PST, Berta József 		rniwa: review-
rniwa: commit-queue-
DetailsFormatted DiffDiff
I have added description to the changelog. Typo corrected. (3.51 KB, patch)
2013-11-25 08:25 PST, Berta József 		rniwa: review+
DetailsFormatted DiffDiff
The changelog is updated. (3.54 KB, patch)
2013-11-26 05:01 PST, Berta József 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Berta József
Comment 1 2013-11-25 05:31:23 PST
Created attachment 217795 [details] The script now indicates the results, and calls sys.exit()
Peter Gal
Comment 2 2013-11-25 07:31:11 PST
Comment on attachment 217795 [details] The script now indicates the results, and calls sys.exit() View in context: https://bugs.webkit.org/attachment.cgi?id=217795&action=review > Tools/Scripts/test-webkit-scripts:84 > + print('test-webkiterl') Typo: 'test-webkiterl' -> 'test-webkitperl'
Ryosuke Niwa
Comment 3 2013-11-25 07:37:29 PST
Comment on attachment 217795 [details] The script now indicates the results, and calls sys.exit() View in context: https://bugs.webkit.org/attachment.cgi?id=217795&action=review > Tools/ChangeLog:7 > + Please explain what kind of changes you're making. r- due to the lack of the change log.
Berta József
Comment 4 2013-11-25 08:25:43 PST
Created attachment 217809 [details] I have added description to the changelog. Typo corrected.
Ryosuke Niwa
Comment 5 2013-11-25 16:55:31 PST
Comment on attachment 217809 [details] I have added description to the changelog. Typo corrected. View in context: https://bugs.webkit.org/attachment.cgi?id=217809&action=review > Tools/ChangeLog:3 > + Cumulative indication of success or failure in test-webkit-scripts Please update this line as I've updated the bug title.
Berta József
Comment 6 2013-11-26 05:01:00 PST
Created attachment 217873 [details] The changelog is updated.
Csaba Osztrogonác
Comment 7 2013-11-29 03:40:32 PST
Comment on attachment 217873 [details] The changelog is updated. It was already r+ -ed, only the changelog was missing. The fixed patch landed in https://trac.webkit.org/changeset/159868
Note You need to log in before you can comment on or make changes to this bug.