Bug 124840 - test-webkit-scripts should show the failing tests and use an appropriate exit code
Summary: test-webkit-scripts should show the failing tests and use an appropriate exit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-25 05:24 PST by Berta József
Modified: 2013-11-29 03:40 PST (History)
2 users (show)

See Also:

Attachments
The script now indicates the results, and calls sys.exit() (2.88 KB, patch)
2013-11-25 05:31 PST, Berta József 		rniwa: review-
rniwa: commit-queue-
Details | Formatted Diff | Diff
I have added description to the changelog. Typo corrected. (3.51 KB, patch)
2013-11-25 08:25 PST, Berta József 		rniwa: review+
Details | Formatted Diff | Diff
The changelog is updated. (3.54 KB, patch)
2013-11-26 05:01 PST, Berta József 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Berta József 2013-11-25 05:24:20 PST 
Display a cumulative indication of success or failure. In addition, call sys.exit() with 0 or 1 depending on that cumulative success or failure.
Comment 1 Berta József 2013-11-25 05:31:23 PST 
Created attachment 217795 [details]
The script now indicates the results, and calls sys.exit()
Comment 2 Peter Gal 2013-11-25 07:31:11 PST 
Comment on attachment 217795 [details]
The script now indicates the results, and calls sys.exit()

View in context: https://bugs.webkit.org/attachment.cgi?id=217795&action=review

> Tools/Scripts/test-webkit-scripts:84
> +                print('test-webkiterl')

Typo: 'test-webkiterl' -> 'test-webkitperl'
Comment 3 Ryosuke Niwa 2013-11-25 07:37:29 PST 
Comment on attachment 217795 [details]
The script now indicates the results, and calls sys.exit()

View in context: https://bugs.webkit.org/attachment.cgi?id=217795&action=review

> Tools/ChangeLog:7
> +

Please explain what kind of changes you're making.
r- due to the lack of the change log.
Comment 4 Berta József 2013-11-25 08:25:43 PST 
Created attachment 217809 [details]
I have added description to the changelog. Typo corrected.
Comment 5 Ryosuke Niwa 2013-11-25 16:55:31 PST 
Comment on attachment 217809 [details]
I have added description to the changelog. Typo corrected.

View in context: https://bugs.webkit.org/attachment.cgi?id=217809&action=review

> Tools/ChangeLog:3
> +        Cumulative indication of success or failure in test-webkit-scripts

Please update this line as I've updated the bug title.
Comment 6 Berta József 2013-11-26 05:01:00 PST 
Created attachment 217873 [details]
The changelog is updated.
Comment 7 Csaba Osztrogonác 2013-11-29 03:40:32 PST 
Comment on attachment 217873 [details]
The changelog is updated.

It was already r+ -ed, only the changelog was missing. The fixed patch landed in https://trac.webkit.org/changeset/159868