Bug 124822 – ImageBuffer::create should return a unique_ptr instead of OwnPtr.

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Brian Burg]

Suggested by darin in review of: https://bugs.webkit.org/show_bug.cgi?id=124325

[Brian Burg]

Created attachment 217772 [details]
v1

[EFL EWS Bot]

Comment on attachment 217772 [details]
v1

Attachment 217772 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/35168398

[EFL EWS Bot]

Comment on attachment 217772 [details]
v1

Attachment 217772 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/35318405

[Brian Burg]

Created attachment 217773 [details]
v2

[EFL EWS Bot]

Comment on attachment 217773 [details]
v2

Attachment 217773 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/36148162

[EFL EWS Bot]

Comment on attachment 217773 [details]
v2

Attachment 217773 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/35188428

[Brian Burg]

Created attachment 217775 [details]
v3

[EFL EWS Bot]

Comment on attachment 217775 [details]
v3

Attachment 217775 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/35358389

[EFL EWS Bot]

Comment on attachment 217775 [details]
v3

Attachment 217775 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/35318411

[kov's GTK+ EWS bot]

Comment on attachment 217775 [details]
v3

Attachment 217775 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/35328394

[Brian Burg]

Created attachment 217805 [details]
v3

[EFL EWS Bot]

Comment on attachment 217805 [details]
v3

Attachment 217805 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/36468068

[Sergio Correia (qrwteyrutiyoup)]

Comment on attachment 217805 [details]
v3

View in context: https://bugs.webkit.org/attachment.cgi?id=217805&action=review

> Source/WebCore/platform/graphics/ImageBuffer.h:84
> +            std::unique_ptr<ImageBuffer> buffer(new ImageBuffer(size, resolutionScale, colorSpace, renderingMode, success));

It might be better to use std::make_unique here: 
auto buffer = std::make_unique<ImageBuffer>(size, resolutionScale, colorSpace, renderingMode, success);

[Brian Burg]

(In reply to comment #13)
> (From update of attachment 217805 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217805&action=review
> 
> > Source/WebCore/platform/graphics/ImageBuffer.h:84
> > +            std::unique_ptr<ImageBuffer> buffer(new ImageBuffer(size, resolutionScale, colorSpace, renderingMode, success));
> 
> It might be better to use std::make_unique here: 
> auto buffer = std::make_unique<ImageBuffer>(size, resolutionScale, colorSpace, renderingMode, success);

Ah, true. Thanks for pointing it out.

[Brian Burg]

Not sure why WK2 EFL bot is hitting an ICE, or why the preflight test is crashy. :-/

[Sergio Correia (qrwteyrutiyoup)]

(In reply to comment #15)
> Not sure why WK2 EFL bot is hitting an ICE, or why the preflight test is crashy. :-/

By the looks of the error message, looks like it hit an OOM condition, which in general isn't related to the patch being tested. Just to make your life harder :)

[Andreas Kling]

Comment on attachment 217805 [details]
v3

r=me.
EFL EWS has been ICE'ing randomly for ages, nothing to do with your patch.

[WebKit Commit Bot]

Comment on attachment 217805 [details]
v3

Clearing flags on attachment: 217805

Committed r159791: <http://trac.webkit.org/changeset/159791>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.