Bug 12482 - Add small-caps to list of traits to ignore as it can be synthesized
Summary: Add small-caps to list of traits to ignore as it can be synthesized
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-30 10:51 PST by Nicholas Shanks
Modified: 2024-04-19 12:24 PDT (History)
3 users (show)

See Also:

Attachments
patch (1.74 KB, patch)
2007-01-30 10:52 PST, Nicholas Shanks 		darin: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicholas Shanks 2007-01-30 10:51:24 PST 
The fix for bug #6146 forgot to handle small-caps, which is also synthesized. Although currently the small-caps trait is not requested (since it is always synthesized), I plan on fixing that. This code ought to be ready to handle requests that include the small-caps trait.
Comment 1 Nicholas Shanks 2007-01-30 10:52:18 PST 
Created attachment 12800 [details]
patch
Comment 2 Darin Adler 2007-01-30 10:53:29 PST 
Comment on attachment 12800 [details]
patch

Need a test case and a ChangeLog entry.
Comment 3 Nicholas Shanks 2007-01-30 18:52:33 PST 
What sort of test case do you suggest? Since font-variant: small-caps doesn't request a font with the NSFontSmallCapsMask trait presently, I don't think it can be tested.
Comment 4 Ahmad Saleem 2024-04-19 12:24:38 PDT 
This patch was modifying 'WebFontCache.mm', which was deleted by this commit:

https://github.com/WebKit/WebKit/commit/cf78b9f051b13cd4ddcfb8bfc570174a6e2faafd

We don't have test case to understand to confirm whether the bug exist or not.

@Vitor - is this applicable any more?