Bug 124796 - REGRESSION (r156291): TileController tiles don't always repaint when they resize
Summary: REGRESSION (r156291): TileController tiles don't always repaint when they resize
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-11-22 15:26 PST by Tim Horton
Modified: 2013-11-24 00:32 PST (History)
3 users (show)

See Also:

Attachments
patch (2.94 KB, patch)
2013-11-22 15:29 PST, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-11-22 15:26:24 PST 
http://trac.webkit.org/changeset/156291 dropped the setNeedsDisplay that was previously moved under platformCALayerDidCreateTiles without moving it back into TileController. This means that when tiles resize, we don't repaint.

<rdar://problem/15537608>
Comment 1 Tim Horton 2013-11-22 15:29:48 PST 
Created attachment 217722 [details]
patch

I'm going to try to make a test now.
Comment 2 Simon Fraser (smfr) 2013-11-22 16:41:24 PST 
Comment on attachment 217722 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217722&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * platform/graphics/ca/mac/TileController.mm:

High level summary please. Why did r156291 break it?
Comment 3 Tim Horton 2013-11-24 00:32:15 PST 
http://trac.webkit.org/changeset/159732