Bug 124795 - [Win] Clean up ColorSpace handling in Windows code
Summary: [Win] Clean up ColorSpace handling in Windows code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 31196
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-22 15:20 PST by Brent Fulgham
Modified: 2013-11-22 16:15 PST (History)
0 users

See Also:


Attachments
Patch (6.11 KB, patch)
2013-11-22 15:28 PST, Brent Fulgham
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-11-22 15:20:21 PST
There were some hard-coded DeviceColorSpace calls in the Windows code that should be revised to match all other platforms.  This patch properly handles the sRGB color space (both on older Windows installations and current software) so that our existing test suites pass. It also removes some hard-coded ColorSpace values that were introduced while correcting a build failure around four years ago that were never revised to take advantage of the API.
Comment 1 Brent Fulgham 2013-11-22 15:28:43 PST
Created attachment 217720 [details]
Patch
Comment 2 Brent Fulgham 2013-11-22 15:44:37 PST
<rdar://problem/7387791>
Comment 3 Tim Horton 2013-11-22 15:55:04 PST
Comment on attachment 217720 [details]
Patch

r+ with the changes discussed on IRC
Comment 4 Brent Fulgham 2013-11-22 16:15:34 PST
Committed r159720: <http://trac.webkit.org/changeset/159720>