Bug 124794 - [WK2] Fix the build of the NetworkProcess on iOS
Summary: [WK2] Fix the build of the NetworkProcess on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-22 15:19 PST by Benjamin Poulain
Modified: 2013-11-22 15:45 PST (History)
0 users

See Also:


Attachments
Patch (3.36 KB, patch)
2013-11-22 15:19 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-11-22 15:19:05 PST
[WK2] Fix the build of the NetworkProcess on iOS
Comment 1 Benjamin Poulain 2013-11-22 15:19:30 PST
Created attachment 217718 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-11-22 15:37:59 PST
Comment on attachment 217718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217718&action=review

> Source/WebKit2/NetworkProcess/AsynchronousNetworkLoaderClient.cpp:71
> -#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
> +#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090)

I wonder if we should be using a USE style macro here, not a PLATFORM one.
Comment 3 Benjamin Poulain 2013-11-22 15:45:17 PST
Comment on attachment 217718 [details]
Patch

Clearing flags on attachment: 217718

Committed r159718: <http://trac.webkit.org/changeset/159718>
Comment 4 Benjamin Poulain 2013-11-22 15:45:18 PST
All reviewed patches have been landed.  Closing bug.