Bug 124793 - CodeBlock::m_numCalleeRegisters shouldn't also mean frame size, frame size needed for exit, or any other unrelated things
Summary: CodeBlock::m_numCalleeRegisters shouldn't also mean frame size, frame size ne...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 116888
  Show dependency tree / graph
 
Reported: 2013-11-22 15:15 PST by Filip Pizlo
Modified: 2013-11-22 16:35 PST (History)
7 users (show)

See Also:

Attachments
the patch (19.66 KB, patch)
2013-11-22 15:19 PST, Filip Pizlo 		mhahnenberg: review+
Details | Formatted Diff | Diff
patch for landing (20.43 KB, patch)
2013-11-22 16:15 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-11-22 15:15:57 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-11-22 15:19:56 PST 
Created attachment 217719 [details]
the patch
Comment 2 Mark Hahnenberg 2013-11-22 15:31:11 PST 
Comment on attachment 217719 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217719&action=review

r=me

> Source/JavaScriptCore/dfg/DFGGraph.cpp:709
> +    unsigned count = m_profiledBlock->m_numCalleeRegisters;

JIT::frameRegisterCountFor(m_profiledBlock)

> Source/JavaScriptCore/dfg/DFGGraph.cpp:713
> +        unsigned requiredCount = VirtualRegister(inlineCallFrame->stackOffset).toLocal() + 1 + codeBlock->m_numCalleeRegisters;

JIT::frameRegisterCountFor(codeBlock)

> Source/JavaScriptCore/dfg/DFGGraph.cpp:715
> +        if (requiredCount > count)
> +            count = requiredCount;

max?
Comment 3 Filip Pizlo 2013-11-22 16:15:17 PST 
Created attachment 217724 [details]
patch for landing
Comment 4 Filip Pizlo 2013-11-22 16:35:48 PST 
Landed in http://trac.webkit.org/changeset/159721