Bug 124788 - [CSS Shapes] Support for shape-margin in BoxShape
Summary: [CSS Shapes] Support for shape-margin in BoxShape
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on:
Blocks: 124173
  Show dependency tree / graph
 
Reported: 2013-11-22 13:10 PST by Hans Muller
Modified: 2013-11-26 11:17 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.33 KB, patch)
2013-11-25 16:50 PST, Hans Muller 		no flags Details | Formatted Diff | Diff
Patch (13.41 KB, patch)
2013-11-26 09:58 PST, Hans Muller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2013-11-22 13:10:31 PST 
Currently specifying shape-margin for box shapes (http://dev.w3.org/csswg/css-shapes/#typedef-box) has no effect.
Comment 1 Hans Muller 2013-11-25 16:50:18 PST 
Created attachment 217848 [details]
Patch

Just giving the bots a crack at an incomplete version of this patch.
Comment 2 Hans Muller 2013-11-26 09:58:25 PST 
Created attachment 217885 [details]
Patch

Corrected BoxShape's internal shape-margin/paddding bounds FloatRoundedRect initialization. Tests for the padding bounds will be added when the rest of shape-padding for box shapes implementation is ready.
Comment 3 Andreas Kling 2013-11-26 10:44:32 PST 
Comment on attachment 217885 [details]
Patch

Nice catch. r=me
Comment 4 WebKit Commit Bot 2013-11-26 11:17:03 PST 
Comment on attachment 217885 [details]
Patch

Clearing flags on attachment: 217885

Committed r159787: <http://trac.webkit.org/changeset/159787>
Comment 5 WebKit Commit Bot 2013-11-26 11:17:05 PST 
All reviewed patches have been landed.  Closing bug.