Bug 124749 - JSC: Removed unused opcodes from offline assembler
Summary: JSC: Removed unused opcodes from offline assembler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-21 16:34 PST by Michael Saboff
Modified: 2013-11-21 16:43 PST (History)
0 users

See Also:


Attachments
Patch (2.25 KB, patch)
2013-11-21 16:41 PST, Michael Saboff
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-11-21 16:34:14 PST
The opcodes peek and pokeq are not currently used by the LLInt and therefore are redundant.  The desire to remove these at this time is due to a limitation in size of regular expressions in ruby.  For the patch https://bugs.webkit.org/show_bug.cgi?id=124721 - "ARM64: Implement push/pop equivalents in LLInt" I'd like to add two new opcodes.  By removing these two opcodes, we can add the opcodes in that patch.
Comment 1 Michael Saboff 2013-11-21 16:41:24 PST
Created attachment 217627 [details]
Patch
Comment 2 Mark Hahnenberg 2013-11-21 16:42:34 PST
Comment on attachment 217627 [details]
Patch

r=me
Comment 3 Michael Saboff 2013-11-21 16:43:49 PST
Committed r159654: <http://trac.webkit.org/changeset/159654>