RESOLVED FIXED 124741
Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard 
https://bugs.webkit.org/show_bug.cgi?id=124741
Summary Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard
Daniel Bates
Reported 2013-11-21 13:09:30 PST
Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard around code that is unused when building without feature NETWORK_CFDATA_ARRAY_CALLBACK.
Attachments
Patch (1.95 KB, patch)
2013-11-21 13:16 PST, Daniel Bates 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2013-11-21 13:15:54 PST
(In reply to comment #0) > Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard around code that is unused when building without feature NETWORK_CFDATA_ARRAY_CALLBACK. *building with
Daniel Bates
Comment 2 2013-11-21 13:16:47 PST
Created attachment 217606 [details] Patch
Alexey Proskuryakov
Comment 3 2013-11-21 13:39:00 PST
Comment on attachment 217606 [details] Patch It's kind of wrong that USE(NETWORK_CFDATA_ARRAY_CALLBACK) affects the behavior of SharedBuffer::append(const char* data, unsigned length). That has nothing to do with CFArrayRef data chunks!
Daniel Bates
Comment 4 2013-11-21 15:19:18 PST
Committed r159650: <http://trac.webkit.org/changeset/159650>
Pratik Solanki
Comment 5 2013-11-21 15:41:57 PST
(In reply to comment #3) > (From update of attachment 217606 [details]) > It's kind of wrong that USE(NETWORK_CFDATA_ARRAY_CALLBACK) affects the behavior of SharedBuffer::append(const char* data, unsigned length). That has nothing to do with CFArrayRef data chunks! Yeah, enabling that define also disables the segmented buffer approach that we have in SharedBuffer (which was added in bug 33178). See bug 77715 and r154823 where I made the data array and segments be mutually exclusive.
Note You need to log in before you can comment on or make changes to this bug.