Bug 124741 - Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard
Summary: Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-21 13:09 PST by Daniel Bates
Modified: 2013-11-21 15:41 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.95 KB, patch)
2013-11-21 13:16 PST, Daniel Bates
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2013-11-21 13:09:30 PST
Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard around code that is unused when building without feature NETWORK_CFDATA_ARRAY_CALLBACK.
Comment 1 Daniel Bates 2013-11-21 13:15:54 PST
(In reply to comment #0)
> Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard around code that is unused when building without feature NETWORK_CFDATA_ARRAY_CALLBACK.

*building with
Comment 2 Daniel Bates 2013-11-21 13:16:47 PST
Created attachment 217606 [details]
Patch
Comment 3 Alexey Proskuryakov 2013-11-21 13:39:00 PST
Comment on attachment 217606 [details]
Patch

It's kind of wrong that USE(NETWORK_CFDATA_ARRAY_CALLBACK) affects the behavior of SharedBuffer::append(const char* data, unsigned length). That has nothing to do with CFArrayRef data chunks!
Comment 4 Daniel Bates 2013-11-21 15:19:18 PST
Committed r159650: <http://trac.webkit.org/changeset/159650>
Comment 5 Pratik Solanki 2013-11-21 15:41:57 PST
(In reply to comment #3)
> (From update of attachment 217606 [details])
> It's kind of wrong that USE(NETWORK_CFDATA_ARRAY_CALLBACK) affects the behavior of SharedBuffer::append(const char* data, unsigned length). That has nothing to do with CFArrayRef data chunks!

Yeah, enabling that define also disables the segmented buffer approach that we have in SharedBuffer (which was added in bug 33178). See bug 77715 and r154823 where I made the data array and segments be mutually exclusive.