Bug 124737 - Web Inspector: [CSS Shapes] Refactor highlighting code to decrease Shapes API surface
Summary: Web Inspector: [CSS Shapes] Refactor highlighting code to decrease Shapes API...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Bear Travis
URL:
Keywords:
Depends on:
Blocks: 124070
  Show dependency tree / graph
 
Reported: 2013-11-21 12:34 PST by Bear Travis
Modified: 2013-11-21 19:14 PST (History)
8 users (show)

See Also:

Attachments
Initial patch (17.71 KB, patch)
2013-11-21 12:49 PST, Bear Travis 		timothy: review+
Details | Formatted Diff | Diff
Renaming buildInspectorPath to buildPath (16.74 KB, patch)
2013-11-21 16:15 PST, Bear Travis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2013-11-21 12:34:46 PST 
The descendants of the Shapes class have to expose some internal workings in order to build the paths for the inspector highlights.
A cleaner implementation would just pass a path or data struct in to the shape to be populated.
Comment 1 Bear Travis 2013-11-21 12:49:40 PST 
Created attachment 217602 [details]
Initial patch
Comment 2 Bear Travis 2013-11-21 16:15:17 PST 
Created attachment 217624 [details]
Renaming buildInspectorPath to buildPath
Comment 3 WebKit Commit Bot 2013-11-21 19:14:50 PST 
Comment on attachment 217624 [details]
Renaming buildInspectorPath to buildPath

Clearing flags on attachment: 217624

Committed r159671: <http://trac.webkit.org/changeset/159671>
Comment 4 WebKit Commit Bot 2013-11-21 19:14:52 PST 
All reviewed patches have been landed.  Closing bug.