RESOLVED FIXED 124736
JSC should know what the stack alignment conventions are 
https://bugs.webkit.org/show_bug.cgi?id=124736
Summary JSC should know what the stack alignment conventions are
Filip Pizlo
Reported 2013-11-21 12:31:55 PST
Patch forthcoming.
Attachments
the patch (11.93 KB, patch)
2013-11-21 12:34 PST, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-11-21 12:34:34 PST
Created attachment 217597 [details] the patch
Mark Lam
Comment 2 2013-11-21 12:49:07 PST
Comment on attachment 217597 [details] the patch r=me
Filip Pizlo
Comment 3 2013-11-21 13:05:48 PST
Landed in http://trac.webkit.org/changeset/159642
Geoffrey Garen
Comment 4 2013-11-21 13:06:09 PST
Comment on attachment 217597 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=217597&action=review > Source/JavaScriptCore/runtime/StackAlignment.h:39 > +unsigned stackAlignmentBytes() { return 16; } > + > +unsigned stackAlignmentRegisters() > +{ > + return stackAlignmentBytes() / sizeof(EncodedJSValue); > +} Please mark as "inline".
Filip Pizlo
Comment 5 2013-11-21 13:10:40 PST
(In reply to comment #4) > (From update of attachment 217597 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=217597&action=review > > > Source/JavaScriptCore/runtime/StackAlignment.h:39 > > +unsigned stackAlignmentBytes() { return 16; } > > + > > +unsigned stackAlignmentRegisters() > > +{ > > + return stackAlignmentBytes() / sizeof(EncodedJSValue); > > +} > > Please mark as "inline". Fixed in http://trac.webkit.org/changeset/159643
Darin Adler
Comment 6 2013-11-21 17:12:32 PST
Comment on attachment 217597 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=217597&action=review > Source/JavaScriptCore/runtime/StackAlignment.h:33 > +// NB. Different platforms may have different requriements here. But 16 bytes is very common. Typo: “requriements”.
Filip Pizlo
Comment 7 2013-11-21 20:22:34 PST
(In reply to comment #6) > (From update of attachment 217597 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=217597&action=review > > > Source/JavaScriptCore/runtime/StackAlignment.h:33 > > +// NB. Different platforms may have different requriements here. But 16 bytes is very common. > > Typo: “requriements”. http://trac.webkit.org/changeset/159677
Note You need to log in before you can comment on or make changes to this bug.