Bug 124736 - JSC should know what the stack alignment conventions are
Summary: JSC should know what the stack alignment conventions are
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 124735
  Show dependency tree / graph
 
Reported: 2013-11-21 12:31 PST by Filip Pizlo
Modified: 2013-11-21 20:22 PST (History)
7 users (show)

See Also:

Attachments
the patch (11.93 KB, patch)
2013-11-21 12:34 PST, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-11-21 12:31:55 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-11-21 12:34:34 PST 
Created attachment 217597 [details]
the patch
Comment 2 Mark Lam 2013-11-21 12:49:07 PST 
Comment on attachment 217597 [details]
the patch

r=me
Comment 3 Filip Pizlo 2013-11-21 13:05:48 PST 
Landed in http://trac.webkit.org/changeset/159642
Comment 4 Geoffrey Garen 2013-11-21 13:06:09 PST 
Comment on attachment 217597 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217597&action=review

> Source/JavaScriptCore/runtime/StackAlignment.h:39
> +unsigned stackAlignmentBytes() { return 16; }
> +
> +unsigned stackAlignmentRegisters()
> +{
> +    return stackAlignmentBytes() / sizeof(EncodedJSValue);
> +}

Please mark as "inline".
Comment 5 Filip Pizlo 2013-11-21 13:10:40 PST 
(In reply to comment #4)
> (From update of attachment 217597 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217597&action=review
> 
> > Source/JavaScriptCore/runtime/StackAlignment.h:39
> > +unsigned stackAlignmentBytes() { return 16; }
> > +
> > +unsigned stackAlignmentRegisters()
> > +{
> > +    return stackAlignmentBytes() / sizeof(EncodedJSValue);
> > +}
> 
> Please mark as "inline".

Fixed in http://trac.webkit.org/changeset/159643
Comment 6 Darin Adler 2013-11-21 17:12:32 PST 
Comment on attachment 217597 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217597&action=review

> Source/JavaScriptCore/runtime/StackAlignment.h:33
> +// NB. Different platforms may have different requriements here. But 16 bytes is very common.

Typo: “requriements”.
Comment 7 Filip Pizlo 2013-11-21 20:22:34 PST 
(In reply to comment #6)
> (From update of attachment 217597 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217597&action=review
> 
> > Source/JavaScriptCore/runtime/StackAlignment.h:33
> > +// NB. Different platforms may have different requriements here. But 16 bytes is very common.
> 
> Typo: “requriements”.

http://trac.webkit.org/changeset/159677