Bug 124716 - [MIPS] Build fails since r159545.
Summary: [MIPS] Build fails since r159545.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-21 07:20 PST by Balazs Kilvady
Modified: 2013-11-21 10:29 PST (History)
8 users (show)

See Also:

Attachments
proposed patch. (2.61 KB, patch)
2013-11-21 09:30 PST, Balazs Kilvady 		no flags Details | Formatted Diff | Diff
fixed patch. (2.60 KB, patch)
2013-11-21 09:39 PST, Balazs Kilvady 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kilvady 2013-11-21 07:20:22 PST 
The "memfence" opcode is missing from LLINT and the following implementations are missing from MacroAssemblerMIPS.h since r159545:
- void memoryFence()
- void store8(RegisterID, const void*)
Comment 1 Balazs Kilvady 2013-11-21 09:30:32 PST 
Created attachment 217576 [details]
proposed patch.
Comment 2 Julien Brianceau 2013-11-21 09:34:04 PST 
Comment on attachment 217576 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=217576&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:998
> +        m_assembler.sb(immTempRegister, addrTempRegister, 0);

Why src RegisterID parameter is not used here?
Comment 3 Balazs Kilvady 2013-11-21 09:39:10 PST 
Created attachment 217577 [details]
fixed patch.
Comment 4 WebKit Commit Bot 2013-11-21 10:29:46 PST 
Comment on attachment 217577 [details]
fixed patch.

Clearing flags on attachment: 217577

Committed r159635: <http://trac.webkit.org/changeset/159635>
Comment 5 WebKit Commit Bot 2013-11-21 10:29:48 PST 
All reviewed patches have been landed.  Closing bug.