Bug 124713 - [sh4] Build fails since r159545
Summary: [sh4] Build fails since r159545
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-21 06:20 PST by Julien Brianceau
Modified: 2013-11-21 09:09 PST (History)
2 users (show)

See Also:

Attachments
Add missing implementations in macro assembler and LLINT for sh4. (3.36 KB, patch)
2013-11-21 06:30 PST, Julien Brianceau 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-11-21 06:20:24 PST 
The "memfence" opcode is missing from LLINT and the following implementations are missing from macro assembler since r159545 for sh4 architecture:
- void memoryFence()
- void load8(const void*, RegisterID)
- void store8(RegisterID, const void*)
Comment 1 Julien Brianceau 2013-11-21 06:30:09 PST 
Created attachment 217557 [details]
Add missing implementations in macro assembler and LLINT for sh4.
Comment 2 WebKit Commit Bot 2013-11-21 06:31:33 PST 
Attachment 217557 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/assembler/MacroAssemblerSH4.h', u'Source/JavaScriptCore/assembler/SH4Assembler.h', u'Source/JavaScriptCore/offlineasm/sh4.rb']" exit_code: 1
Source/JavaScriptCore/assembler/SH4Assembler.h:185:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2013-11-21 09:09:11 PST 
Comment on attachment 217557 [details]
Add missing implementations in macro assembler and LLINT for sh4.

Clearing flags on attachment: 217557

Committed r159629: <http://trac.webkit.org/changeset/159629>
Comment 4 WebKit Commit Bot 2013-11-21 09:09:14 PST 
All reviewed patches have been landed.  Closing bug.