RESOLVED FIXED 124707
Generate toHTMLMarquee|OListElement() to cleanup static_cast<> 
https://bugs.webkit.org/show_bug.cgi?id=124707
Summary Generate toHTMLMarquee|OListElement() to cleanup static_cast<>
Gyuyoung Kim
Reported 2013-11-21 03:10:15 PST
As a step to use toFoo(), we need to generate toHTMLMarquee|OListElement(). Besides this patch cleans up remaining static_cast<> usage.
Attachments
Patch (18.54 KB, patch)
2013-11-21 03:17 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (18.58 KB, patch)
2013-11-22 23:44 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2013-11-21 03:17:48 PST
Created attachment 217542 [details] Patch
Gyuyoung Kim
Comment 2 2013-11-21 18:36:39 PST
Comment on attachment 217542 [details] Patch There is no regression on layout test when I run layout test locally.
Gyuyoung Kim
Comment 3 2013-11-21 20:28:23 PST
CC'ing Darin.
Darin Adler
Comment 4 2013-11-22 08:18:30 PST
Comment on attachment 217542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217542&action=review > Source/WebCore/rendering/RenderMarquee.cpp:78 > if (element && element->hasTagName(marqueeTag)) { > - HTMLMarqueeElement* marqueeElement = static_cast<HTMLMarqueeElement*>(element); > - result = std::max(result, marqueeElement->minimumDelay()); > + result = std::max(result, toHTMLMarqueeElement(element)->minimumDelay()); > } WebKit coding style says we remove the braces when an if statement becomes a single line like this.
Gyuyoung Kim
Comment 5 2013-11-22 23:44:25 PST
Created attachment 217742 [details] Patch
WebKit Commit Bot
Comment 6 2013-11-24 07:23:18 PST
Comment on attachment 217742 [details] Patch Clearing flags on attachment: 217742 Committed r159733: <http://trac.webkit.org/changeset/159733>
WebKit Commit Bot
Comment 7 2013-11-24 07:23:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.