Bug 124704 – Fix WinCairo unreachable code warnings in SimpleLineLayout.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Laszlo Vidacs]

Early return causes unreachable code warnings on specific platforms.

http://build.webkit.org/builders/WinCairo%20Release/builds/33430/steps/compile-webkit/logs/stdio

[Laszlo Vidacs]

Created attachment 217535 [details]
Patch

[Antti Koivisto]

Comment on attachment 217535 [details]
Patch

You should fix the warning settings instead.

[Csaba Osztrogonác]

(In reply to comment #2)
> (From update of attachment 217535 [details])
> You should fix the warning settings instead.

Do you really prefer ignoring unreachable code warnings instead of 
getting rid the unreachable codes from the source with proper guarding?

I don't think if it is a good idea.

[Antti Koivisto]

One port using different warning settings than every other port just creates churn.

[Csaba Osztrogonác]

(In reply to comment #4)
> One port using different warning settings than every other port just creates churn.

It's not a about warning settings. There is an ifdef guard:
"#if !PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL)" with early return.

After the #endif everything is unreachable code on all platform
which is not Mac, GTK and EFL. Unreachable code is unreachable code 
and not warning setting.

[Antti Koivisto]

Comment on attachment 217535 [details]
Patch

Ok ok. The real solution here is to remove the whole ifdef and fix the 8bit run issues. That should really be done by people maintaining these platforms.

[WebKit Commit Bot]

Comment on attachment 217535 [details]
Patch

Clearing flags on attachment: 217535

Committed r159666: <http://trac.webkit.org/changeset/159666>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.