Bug 124694 - Allow settings to be shown/hidden on build.webkit.org/dashboard
Summary: Allow settings to be shown/hidden on build.webkit.org/dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-20 17:42 PST by Dean Jackson
Modified: 2013-11-20 17:59 PST (History)
0 users

See Also:

Attachments
Patch (6.41 KB, patch)
2013-11-20 17:45 PST, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-11-20 17:42:24 PST 
In preparation for more options, add a way to hide all the goop on the dashboard.
This patch adds a little gear icon in the top left which toggles all the settings.
Comment 1 Dean Jackson 2013-11-20 17:45:21 PST 
Created attachment 217506 [details]
Patch
Comment 2 Tim Horton 2013-11-20 17:52:59 PST 
Comment on attachment 217506 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217506&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:181
> +    settingsButton.addEventListener("click", function () { settings.toggleSettingsDisplay(); });

space before ()? I don't remember
Comment 3 Dean Jackson 2013-11-20 17:59:04 PST 
Committed r159602: <http://trac.webkit.org/changeset/159602>