Bug 124689 – Add argument coders for IDBDatabaseMetadata

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

Add argument coders for IDBDatabaseMetadata

They will be used shortly for upcoming patches related to https://bugs.webkit.org/show_bug.cgi?id=124521

This is such a separable piece of work it makes it easier to review as a separate patch.

[Brady Eidson]

Created attachment 217497 [details]
Patch v1

[WebKit Commit Bot]

Attachment 217497 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebCoreArgumentCoders.cpp', u'Source/WebKit2/Shared/WebCoreArgumentCoders.h']" exit_code: 1
Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1394:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 217497 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=217497&action=review

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1394
> +    case IDBKeyPath::StringType:
> +    {

Brace should go on same line as the case.

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1403
> +    case IDBKeyPath::ArrayType:
> +    {

Ditto.

[Brady Eidson]

http://trac.webkit.org/changeset/159597