Bug 124689 - Add argument coders for IDBDatabaseMetadata
Summary: Add argument coders for IDBDatabaseMetadata
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 124521
  Show dependency tree / graph
 
Reported: 2013-11-20 17:00 PST by Brady Eidson
Modified: 2013-11-20 17:09 PST (History)
3 users (show)

See Also:

Attachments
Patch v1 (6.63 KB, patch)
2013-11-20 17:03 PST, Brady Eidson 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-11-20 17:00:53 PST 
Add argument coders for IDBDatabaseMetadata

They will be used shortly for upcoming patches related to https://bugs.webkit.org/show_bug.cgi?id=124521

This is such a separable piece of work it makes it easier to review as a separate patch.
Comment 1 Brady Eidson 2013-11-20 17:03:02 PST 
Created attachment 217497 [details]
Patch v1
Comment 2 WebKit Commit Bot 2013-11-20 17:04:30 PST 
Attachment 217497 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebCoreArgumentCoders.cpp', u'Source/WebKit2/Shared/WebCoreArgumentCoders.h']" exit_code: 1
Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1394:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2013-11-20 17:04:39 PST 
Comment on attachment 217497 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=217497&action=review

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1394
> +    case IDBKeyPath::StringType:
> +    {

Brace should go on same line as the case.

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1403
> +    case IDBKeyPath::ArrayType:
> +    {

Ditto.
Comment 4 Brady Eidson 2013-11-20 17:09:27 PST 
http://trac.webkit.org/changeset/159597