Bug 124688 - REGRESSION(159395) Fix branch8(…, AbsoluteAddress, …) in ARM64 MacroAssembler
Summary: REGRESSION(159395) Fix branch8(…, AbsoluteAddress, …) in ARM64 MacroAssembler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-20 16:27 PST by Michael Saboff
Modified: 2013-11-21 16:29 PST (History)
0 users

See Also:


Attachments
Patch (1.48 KB, patch)
2013-11-21 16:13 PST, Michael Saboff
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-11-20 16:27:31 PST
Since http://trac.webkit.org/changeset/159395, ARM64 build won't compile due to broken implementation of branch8(RelationalCondition cond, AbsoluteAddress left, TrustedImm32 right).

The load8() of the AbsoluteAddress needs to be handle differently.
Comment 1 Michael Saboff 2013-11-21 16:13:58 PST
Created attachment 217623 [details]
Patch
Comment 2 Geoffrey Garen 2013-11-21 16:17:05 PST
Comment on attachment 217623 [details]
Patch

r=me
Comment 3 Michael Saboff 2013-11-21 16:29:34 PST
Committed r159653: <http://trac.webkit.org/changeset/159653>