ASSIGNED 124682
[ASAN] WebKitTestRunner can only load its injected bundle at the "mainBundle" path 
https://bugs.webkit.org/show_bug.cgi?id=124682
Summary [ASAN] WebKitTestRunner can only load its injected bundle at the "mainBundle"...
David Farler
Reported 2013-11-20 15:06:14 PST
WebKitTestRunner can't run without the WebKitTestRunnerInjectedBundle.bundle, however WKTR only looks in the "mainBundle" path and gives up. For ASAN "nightly" style app bundles, that is the root of the app bundle. I'd like to place this injected bundle in ./Contents/Resources, so we need to add a second check to look in this subdirectory before giving up.
Attachments
Patch (1.88 KB, patch)
2013-11-21 10:59 PST, David Farler 		bfulgham: review+
bfulgham: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Farler
Comment 1 2013-11-21 10:59:01 PST
Created attachment 217584 [details] Patch
Brent Fulgham
Comment 2 2013-11-26 19:01:41 PST
Comment on attachment 217584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217584&action=review r=me with minor space adjustments to meet code style guidelines. > Tools/WebKitTestRunner/mac/TestControllerMac.mm:61 > + if (![[NSFileManager defaultManager] fileExistsAtPath:nsBundlePath]) Missing a space between "fileExistsAtPath:" and its argument. > Tools/WebKitTestRunner/mac/TestControllerMac.mm:62 > + nsBundlePath = [[[NSBundle mainBundle] bundlePath] stringByAppendingPathComponent:@"Contents/Resources/WebKitTestRunnerInjectedBundle.bundle"]; Missing space between "stringByAppendingPathComponent:" and its argument.
Note You need to log in before you can comment on or make changes to this bug.