Bug 124681 - Enable PageLoadTest assertions again
Summary: Enable PageLoadTest assertions again
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
Depends on:
Reported: 2013-11-20 15:00 PST by Anders Carlsson
Modified: 2014-09-01 06:41 PDT (History)
0 users

See Also:

Patch (4.84 KB, patch)
2013-11-20 15:04 PST, Anders Carlsson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-11-20 15:00:50 PST
Enable PageLoadTest assertions again
Comment 1 Anders Carlsson 2013-11-20 15:04:39 PST
Created attachment 217484 [details]
Comment 2 Anders Carlsson 2013-11-20 15:20:19 PST
Committed r159586: <http://trac.webkit.org/changeset/159586>
Comment 3 Carlos Garcia Campos 2014-09-01 06:41:48 PDT
Comment on attachment 217484 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=217484&action=review

> Source/WebKit2/UIProcess/PageLoadState.cpp:112
> -    ASSERT(!m_url.isEmpty());
> +

Why was this wrong? shouldn't we reset the url in didStartProvisionalLoad? I've noticed a problem because of this:

1.- load something successfully, m_url is updated
2.- load something that fails
3.- the active URL is the one from the previous load, because at this point the pending API request URL has been reset, there's no unreachable URL and state finish. 

I also wonder if we should use the provisional URL as the unreachable one in case of provisional load failure, when there's no last unreachable url. We should definitely add a unit tests for these things.