RESOLVED FIXED 124676
webkitdirs::checkForArgumentAndRemoveFromArrayRef() removes wrong element 
https://bugs.webkit.org/show_bug.cgi?id=124676
Summary webkitdirs::checkForArgumentAndRemoveFromArrayRef() removes wrong element
Nick Diego Yamane (diegoyam)
Reported 2013-11-20 13:56:03 PST
webkitdirs::checkForArgumentAndRemoveFromArrayRef remove wrong elements when there were more then one occurrence of that argument. E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be {b, a}, when it should be {b, c}.
Attachments
Patch (4.84 KB, patch)
2013-11-20 14:22 PST, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.56 KB, patch)
2013-11-21 07:32 PST, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Patch for landing 2 (4.53 KB, patch)
2013-11-21 08:05 PST, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Patch (4.74 KB, patch)
2013-11-21 09:11 PST, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Nick Diego Yamane (diegoyam)
Comment 1 2013-11-20 14:22:05 PST
Created attachment 217480 [details] Patch
Daniel Bates
Comment 2 2013-11-20 17:10:43 PST
Comment on attachment 217480 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217480&action=review This patch look a reasonable to me. Ideally, we could reduce some duplication of code in the unit test. For now, it's OK. > Tools/ChangeLog:3 > + Fix a bug in webkitdirs::checkForArgumentAndRemoveFromArrayRef This title is ambiguous. I updated the Bugzilla bug title to be: webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element Feel free to use this bug title or come up with a more descriptive one.
Nick Diego Yamane (diegoyam)
Comment 3 2013-11-21 07:32:36 PST
Created attachment 217567 [details] Patch for landing
Nick Diego Yamane (diegoyam)
Comment 4 2013-11-21 08:05:12 PST
Created attachment 217570 [details] Patch for landing 2
Nick Diego Yamane (diegoyam)
Comment 5 2013-11-21 09:11:01 PST
Created attachment 217575 [details] Patch
WebKit Commit Bot
Comment 6 2013-11-21 18:59:29 PST
Comment on attachment 217575 [details] Patch Clearing flags on attachment: 217575 Committed r159668: <http://trac.webkit.org/changeset/159668>
WebKit Commit Bot
Comment 7 2013-11-21 18:59:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.