RESOLVED INVALID 124670
[Win] GraphicsSurfaceWin.cpp is missing after r156795 
https://bugs.webkit.org/show_bug.cgi?id=124670
Summary [Win] GraphicsSurfaceWin.cpp is missing after r156795
Arunprasad Rajkumar
Reported 2013-11-20 10:38:34 PST
GraphicsSurfaceWin.cpp is available at http://trac.webkit.org/log/trunk/Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp?rev=156794 but missing after http://trac.webkit.org/changeset/156795. But SVN log doesn't show that file is removed. Something weird is happening!!
Attachments
Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-11-20 10:46:55 PST
This file (and several others) were removed in https://bugs.webkit.org/show_bug.cgi?id=122228. SVN/Trac history shows this, so I don't see anything wrong.
Arunprasad Rajkumar
Comment 2 2013-11-20 19:52:54 PST
(In reply to comment #1) > This file (and several others) were removed in https://bugs.webkit.org/show_bug.cgi?id=122228. > > SVN/Trac history shows this, so I don't see anything wrong. I misunderstood :( I thought like GraphicsSurfaceWin.cpp also used in WK2- WinCairo for WebGL. Is it not so?
Brent Fulgham
Comment 3 2013-11-20 20:02:24 PST
(In reply to comment #2) > (In reply to comment #1) > > This file (and several others) were removed in https://bugs.webkit.org/show_bug.cgi?id=122228. > > > > SVN/Trac history shows this, so I don't see anything wrong. > > I misunderstood :( I thought like GraphicsSurfaceWin.cpp also used in WK2- WinCairo for WebGL. Is it not so? The original Windows build of WebKit2 was removed a while ago. It hasn't been used or maintained for some time.
Arunprasad Rajkumar
Comment 4 2013-11-20 20:13:44 PST
(In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > This file (and several others) were removed in https://bugs.webkit.org/show_bug.cgi?id=122228. > > > > > > SVN/Trac history shows this, so I don't see anything wrong. > > > > I misunderstood :( I thought like GraphicsSurfaceWin.cpp also used in WK2- WinCairo for WebGL. Is it not so? > > The original Windows build of WebKit2 was removed a while ago. It hasn't been used or maintained for some time. So how the WebGL works in WinCairo without a GraphicsSurface implementation? Is it uses something from CoreGraphics/CoreAnimation?
Arunprasad Rajkumar
Comment 5 2013-11-20 20:14:14 PST
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (In reply to comment #1) > > > > This file (and several others) were removed in https://bugs.webkit.org/show_bug.cgi?id=122228. > > > > > > > > SVN/Trac history shows this, so I don't see anything wrong. > > > > > > I misunderstood :( I thought like GraphicsSurfaceWin.cpp also used in WK2- WinCairo for WebGL. Is it not so? > > > > The original Windows build of WebKit2 was removed a while ago. It hasn't been used or maintained for some time. > > So how the WebGL works in WinCairo without a GraphicsSurface implementation? Is it uses something from CoreGraphics/CoreAnimation? I meant WK1-WinCairo :)
Note You need to log in before you can comment on or make changes to this bug.