Bug 124668 - Rename IDBMetadata.h to IDBDatabaseMetadata.h
Summary: Rename IDBMetadata.h to IDBDatabaseMetadata.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-20 09:56 PST by Brady Eidson
Modified: 2013-11-20 10:06 PST (History)
3 users (show)

See Also:

Attachments
Patch v1 (24.16 KB, patch)
2013-11-20 09:57 PST, Brady Eidson 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-11-20 09:56:08 PST 
Rename IDBMetadata.h to IDBDatabaseMetadata.h

The primary class in the header is IDBDatabaseMetadata.  The header name should match that.
Comment 1 Brady Eidson 2013-11-20 09:57:12 PST 
Created attachment 217450 [details]
Patch v1
Comment 2 WebKit Commit Bot 2013-11-20 09:59:25 PST 
Attachment 217450 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/indexeddb/IDBDatabase.h', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackend.h', u'Source/WebCore/Modules/indexeddb/IDBDatabaseMetadata.h', u'Source/WebCore/Modules/indexeddb/IDBIndex.h', u'Source/WebCore/Modules/indexeddb/IDBMetadata.h', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.h', u'Source/WebCore/Modules/indexeddb/IDBServerConnection.h', u'Source/WebCore/Modules/indexeddb/IDBTransaction.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBIndexWriterLevelDB.h', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/inspector/InspectorIndexedDBAgent.cpp']" exit_code: 1
Source/WebCore/Modules/indexeddb/IDBObjectStore.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:55:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/indexeddb/IDBIndex.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/indexeddb/IDBDatabaseBackend.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 6 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2013-11-20 10:01:09 PST 
http://trac.webkit.org/changeset/159567

But I failed on the sorting!  Will followup.
Comment 4 Brady Eidson 2013-11-20 10:06:53 PST 
http://trac.webkit.org/changeset/159568