RESOLVED FIXED 124668
Rename IDBMetadata.h to IDBDatabaseMetadata.h 
https://bugs.webkit.org/show_bug.cgi?id=124668
Summary Rename IDBMetadata.h to IDBDatabaseMetadata.h
Brady Eidson
Reported 2013-11-20 09:56:08 PST
Rename IDBMetadata.h to IDBDatabaseMetadata.h The primary class in the header is IDBDatabaseMetadata. The header name should match that.
Attachments
Patch v1 (24.16 KB, patch)
2013-11-20 09:57 PST, Brady Eidson 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2013-11-20 09:57:12 PST
Created attachment 217450 [details] Patch v1
WebKit Commit Bot
Comment 2 2013-11-20 09:59:25 PST
Attachment 217450 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/indexeddb/IDBDatabase.h', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackend.h', u'Source/WebCore/Modules/indexeddb/IDBDatabaseMetadata.h', u'Source/WebCore/Modules/indexeddb/IDBIndex.h', u'Source/WebCore/Modules/indexeddb/IDBMetadata.h', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.h', u'Source/WebCore/Modules/indexeddb/IDBServerConnection.h', u'Source/WebCore/Modules/indexeddb/IDBTransaction.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBIndexWriterLevelDB.h', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/inspector/InspectorIndexedDBAgent.cpp']" exit_code: 1 Source/WebCore/Modules/indexeddb/IDBObjectStore.h:34: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:55: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:38: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/Modules/indexeddb/IDBIndex.h:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:34: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/Modules/indexeddb/IDBDatabaseBackend.h:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 6 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 3 2013-11-20 10:01:09 PST
http://trac.webkit.org/changeset/159567 But I failed on the sorting! Will followup.
Brady Eidson
Comment 4 2013-11-20 10:06:53 PST
http://trac.webkit.org/changeset/159568
Note You need to log in before you can comment on or make changes to this bug.