setGstBufferSize allows an "int" typed value as newSize and casts to unsigned "gsize" type for the 0.10 version.
Created attachment 217428 [details] Patch
Comment on attachment 217428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217428&action=review setGstBufferSize will be going away once the GStreamer 0.10 code is removed. It might be better to re-evaluate your patch then. > Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp:166 > + ASSERT((static_cast<gint64>(G_MINSSIZE) > newSize) > + || (static_cast<gint64>(G_MAXSSIZE) < newSize)); This should be one line. > Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp:171 > + ASSERT((0 > newSize) > + || (static_cast<gint64>(G_MAXUINT) < newSize)); Ditto.
(In reply to comment #2) > (From update of attachment 217428 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=217428&action=review > > setGstBufferSize will be going away once the GStreamer 0.10 code is removed. It might be better to re-evaluate your patch then. Blocking with bug 124534 , then. > > Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp:166 > > + ASSERT((static_cast<gint64>(G_MINSSIZE) > newSize) > > + || (static_cast<gint64>(G_MAXSSIZE) < newSize)); > > This should be one line. Just to know for further patches. I was just following the recommendation in the point 5. of the "Indentation" section at: http://www.webkit.org/coding/coding-style.html Then, which is the maximum line length or when it is OK to write a sentence in more than one line?
After closing bug 124534 this becomes INVALID.
Comment on attachment 217428 [details] Patch Clearing the reviewing flags since the patch was closed as invalid.